-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Semester 1 (Early-Start) and Semester 1 (Extended) subjects are not included. #12
Comments
Sure, the more periods covered the better, I guess! This will also entail front-end work to add it to the drop down list. Let me know if you need some guidance. |
Will do :) |
Hm actually, are you sure the premise is correct? Seems like I've grouped them all under Semester 1/2 |
If you look at If you look on the handbook at how many subjects there are with semester 1 including early and extended starts, there are 2421 subjects! When you select only Semester 1 it drops down to 2078 subjects, however, that's still not the 2099 that the previous json has -- not sure where that discrepancy of 21 is coming from. But I am pretty sure that the larger discrepenacy is from not including early and extended start subjects. |
Just realized this working on
subjectListScraper.ts
, is it desired to have these subjects included?If it is desired I will make a PR updating the scraper functionality to include these.
Edit: same for semester 2
The text was updated successfully, but these errors were encountered: