From 14a31e0014cf0553b4a6b751564d09c539d642e1 Mon Sep 17 00:00:00 2001
From: killerwife <killerwife@gmail.com>
Date: Sat, 8 Jun 2024 13:51:24 +0200
Subject: [PATCH 1/5] Add support for 65th sql flag

---
 WowPacketParser/Misc/Extensions.cs         | 18 ++++++++++++++++++
 WowPacketParser/Misc/Settings.cs           |  8 ++++----
 WowPacketParser/Store/StoreDictionaries.cs |  2 +-
 3 files changed, 23 insertions(+), 5 deletions(-)

diff --git a/WowPacketParser/Misc/Extensions.cs b/WowPacketParser/Misc/Extensions.cs
index 66d5421a93..e8c82fc5df 100644
--- a/WowPacketParser/Misc/Extensions.cs
+++ b/WowPacketParser/Misc/Extensions.cs
@@ -56,6 +56,24 @@ public static bool HasAnyFlagBit(this IConvertible value, IConvertible bit)
             return (uThis & uFlag) != 0;
         }
 
+        /// <summary>
+        /// Returns true if bit is set in value (&)
+        /// </summary>
+        /// <param name="value">An enum, int, ...</param>
+        /// <param name="bit">An int</param>
+        /// <returns>A boolean</returns>
+        public static bool HasAnyFlagBit(this UInt128 value, IConvertible bit) // uint128 doesnt implement IConvertible
+        {
+            var uBit = bit.ToInt32(null);
+
+            Contract.Assert(uBit >= 0 && uBit <= 127);
+
+            var uFlag = ((UInt128)1) << uBit;
+            var uThis = value;
+
+            return (uThis & uFlag) != 0;
+        }
+
         /// <summary>
         /// Return true if our string is a substring of any filter (case insensitive)
         /// </summary>
diff --git a/WowPacketParser/Misc/Settings.cs b/WowPacketParser/Misc/Settings.cs
index cc1ec55737..38640f8539 100644
--- a/WowPacketParser/Misc/Settings.cs
+++ b/WowPacketParser/Misc/Settings.cs
@@ -19,7 +19,7 @@ public static class Settings
         public static readonly TargetedDatabase TargetedDatabase = Conf.GetEnum("TargetedDatabase", TargetedDatabase.WrathOfTheLichKing);
         public static readonly TargetedProject TargetedProject = Conf.GetEnum("TargetedProject", TargetedProject.TrinityCore);
         public static readonly DumpFormatType DumpFormat = Conf.GetEnum("DumpFormat", DumpFormatType.Text);
-        public static readonly ulong SQLOutputFlag = GetSQLOutputFlag();
+        public static readonly UInt128 SQLOutputFlag = GetSQLOutputFlag();
         public static readonly bool SQLOrderByKey = Conf.GetBoolean("SqlOrderByKey", false);
         public static readonly bool SaveTempSpawns = Conf.GetBoolean("SaveTempSpawns", false);
         public static readonly bool SaveExistingSpawns = Conf.GetBoolean("SaveExistingSpawns", false);
@@ -68,17 +68,17 @@ public static class Settings
         public static readonly bool UseDBC = Conf.GetBoolean("UseDBC", false);
         public static readonly bool ParseSpellInfos = Conf.GetBoolean("ParseSpellInfos", false);
 
-        private static ulong GetSQLOutputFlag()
+        private static UInt128 GetSQLOutputFlag()
         {
             var names = Enum.GetNames(typeof(SQLOutput));
             var values = Enum.GetValues(typeof(SQLOutput));
 
-            var result = 0ul;
+            UInt128 result = 0;
 
             for (var i = 0; i < names.Length; ++i)
             {
                 if (Conf.GetBoolean(names[i], false))
-                    result += (1ul << (int)values.GetValue(i));
+                    result += (((UInt128)1) << (int)values.GetValue(i));
             }
 
             return result;
diff --git a/WowPacketParser/Store/StoreDictionaries.cs b/WowPacketParser/Store/StoreDictionaries.cs
index e76d0f519d..f8650f5948 100644
--- a/WowPacketParser/Store/StoreDictionaries.cs
+++ b/WowPacketParser/Store/StoreDictionaries.cs
@@ -12,7 +12,7 @@ namespace WowPacketParser.Store
 {
     public abstract class Store
     {
-        public static ulong SQLEnabledFlags { protected get; set; }
+        public static UInt128 SQLEnabledFlags { protected get; set; }
         public List<SQLOutput> Types { get; protected set; }
 
         protected bool ProcessFlags()

From bfd0ff8446480e3211f60812d8b15d73dee217bf Mon Sep 17 00:00:00 2001
From: killerwife <killerwife@gmail.com>
Date: Sat, 8 Jun 2024 13:51:33 +0200
Subject: [PATCH 2/5] Implement waypoint sql generation

---
 WowPacketParser/App.config                    |  11 +-
 WowPacketParser/Enums/SQLOutput.cs            |   1 +
 WowPacketParser/Misc/Settings.cs              |   1 +
 WowPacketParser/SQL/Builders/Movement.cs      | 118 ++++++++++++++++++
 .../Objects/Movement/CreatureMovement.cs      |  16 +++
 .../Objects/Movement/CreatureMovementFlags.cs |  12 ++
 .../Objects/Movement/CreatureMovementNode.cs  |  10 ++
 WowPacketParser/Store/Storage.cs              |   4 +
 .../Parsers/UpdateHandler.cs                  |  46 ++++++-
 .../Parsers/MovementHandler.cs                |  56 ++++++++-
 .../Parsers/MovementHandler.cs                |  72 +++++++++--
 11 files changed, 332 insertions(+), 15 deletions(-)
 create mode 100644 WowPacketParser/SQL/Builders/Movement.cs
 create mode 100644 WowPacketParser/Store/Objects/Movement/CreatureMovement.cs
 create mode 100644 WowPacketParser/Store/Objects/Movement/CreatureMovementFlags.cs
 create mode 100644 WowPacketParser/Store/Objects/Movement/CreatureMovementNode.cs

diff --git a/WowPacketParser/App.config b/WowPacketParser/App.config
index 99a20f2315..484c562c73 100644
--- a/WowPacketParser/App.config
+++ b/WowPacketParser/App.config
@@ -202,6 +202,8 @@
         <add key="hotfix_optional_data"                   value="false"/>
         <add key="hotfixes"                               value="false"/>
 
+        <add key="creature_movement"                      value="false"/>
+
 
         <!--
                  Option:      ParseAllHotfixes
@@ -253,11 +255,18 @@
         <add key="GenerateCreateObject2SpawnsOnly" value="false"/>
 
         <!--
+               Option:      SkipIntermediatePoints
+               Description: Skips intermediate points for waypoint paths
+               Default:     "true"
+        -->
+        <add key="SkipIntermediatePoints" value="false"/>
+
+      <!--
                Option:      SkipDuplicateSpawns
                Description: Skip generation of duplicate spawns (grouped by: entry, phases, position)
                Default:     "true"
         -->
-        <add key="SkipDuplicateSpawns" value="true"/>
+      <add key="SkipDuplicateSpawns" value="true"/>
 
         <!--
              Option:      SplitSQLFile
diff --git a/WowPacketParser/Enums/SQLOutput.cs b/WowPacketParser/Enums/SQLOutput.cs
index a24439a9d5..ca3142a687 100644
--- a/WowPacketParser/Enums/SQLOutput.cs
+++ b/WowPacketParser/Enums/SQLOutput.cs
@@ -19,6 +19,7 @@ public enum SQLOutput
         creature_addon,
         creature_equip_template,
         creature_model_info,
+        creature_movement,
         creature_queststarter,
         creature_questender,
         creature_template,
diff --git a/WowPacketParser/Misc/Settings.cs b/WowPacketParser/Misc/Settings.cs
index 38640f8539..7f454ce9b7 100644
--- a/WowPacketParser/Misc/Settings.cs
+++ b/WowPacketParser/Misc/Settings.cs
@@ -32,6 +32,7 @@ public static class Settings
         public static readonly bool ForcePhaseZero = Conf.GetBoolean("ForcePhaseZero", false);
         public static readonly bool GenerateCreateObject2SpawnsOnly = Conf.GetBoolean("GenerateCreateObject2SpawnsOnly", false);
         public static readonly bool SkipDuplicateSpawns = Conf.GetBoolean("SkipDuplicateSpawns", false);
+        public static readonly bool SkipIntermediatePoints = Conf.GetBoolean("SkipDuplicateSpawns", false);
         public static readonly string SQLFileName = Conf.GetString("SQLFileName", string.Empty);
         public static readonly bool SplitSQLFile = Conf.GetBoolean("SplitSQLFile", false);
         public static readonly bool ShowEndPrompt = Conf.GetBoolean("ShowEndPrompt", false);
diff --git a/WowPacketParser/SQL/Builders/Movement.cs b/WowPacketParser/SQL/Builders/Movement.cs
new file mode 100644
index 0000000000..6517d56526
--- /dev/null
+++ b/WowPacketParser/SQL/Builders/Movement.cs
@@ -0,0 +1,118 @@
+using System;
+using WowPacketParser.Enums;
+using WowPacketParser.Misc;
+using WowPacketParser.Store;
+using WowPacketParser.SQL;
+using System.Linq;
+
+namespace WowPacketParser.SQL.Builders
+{
+    [BuilderClass]
+    public static class Movement
+    {
+        [BuilderMethod]
+        public static string MovementData()
+        {
+            if (Storage.CreatureMovement.IsEmpty())
+                return string.Empty;
+
+            if (!Settings.SQLOutputFlag.HasAnyFlagBit(SQLOutput.creature_movement))
+                return string.Empty;
+
+            string output = "SET @MOVID = 0;\n";
+            int pathIdCounter = 0;
+            if (Settings.TargetedProject == TargetedProject.Cmangos)
+            {
+                string nodeSql = "INSERT INTO waypoint_path (PathId, Point, PositionX, PositionY, PositionZ, Orientation, WaitTime, ScriptId, Comment) VALUES\n";
+                foreach (var data in Storage.CreatureMovement.ToList())
+                {
+                    var creatureMovement = data.Item1;
+                    if (creatureMovement.Waypoints.Count == 0)
+                        continue;
+
+                    string creatureName = SQLUtil.EscapeString(StoreGetters.GetName(Utilities.ObjectTypeToStore(creatureMovement.GUID.GetObjectType()), (int)creatureMovement.GUID.GetEntry()));
+                    output += "-- " + $"GUID: {creatureMovement.GUID} PathType: {creatureMovement.Type}" + "\n" + $"INSERT INTO waypoint_path_name(PathId, Name) VALUES(@MOVID + {pathIdCounter},'{creatureName}');\n" + nodeSql;
+
+                    int pointIdCounter = 1;
+                    int actualPoint = 1;
+                    foreach (var node in creatureMovement.Waypoints)
+                    {
+                        bool finalP = creatureMovement.Destination == null && creatureMovement.Waypoints.Count == actualPoint;
+                        ++actualPoint;
+                        float ori = finalP ? (creatureMovement.FinalOrientation != null ? creatureMovement.FinalOrientation.Value : 100f) : 100f;
+                        if (node.Point == false)
+                        {
+                            if (Settings.SkipIntermediatePoints == true)
+                                continue;
+                            output += "-- ";
+                        }
+
+                        output += $"(@MOVID + {pathIdCounter}, '{pointIdCounter}', '{node.Position.X}', '{node.Position.Y}', '{node.Position.Z}', '{ori}', '0', '0', NULL)";
+                        
+                        if (!finalP)
+                            output += ",\n";
+                        else
+                            output += ";\n\n";
+                        
+                        ++pointIdCounter;
+                    }
+
+                    if (creatureMovement.Destination != null)
+                    {
+                        float ori = creatureMovement.FinalOrientation != null ? creatureMovement.FinalOrientation.Value : 100f;
+                        output += $"(@MOVID + {pathIdCounter}, '{pointIdCounter}', '{creatureMovement.Destination.Position.X}', '{creatureMovement.Destination.Position.Y}', '{creatureMovement.Destination.Position.Z}', '{ori}', '0', '0', NULL);\n";
+                    }
+
+                    ++pathIdCounter;
+                }
+            }
+            else if (Settings.TargetedProject == TargetedProject.TrinityCore)
+            {
+                string nodeSql = "INSERT INTO waypoint_path_node (PathId, NodeId, PositionX, PositionY, PositionZ, Orientation, Delay) VALUES\n";
+                foreach (var data in Storage.CreatureMovement.ToList())
+                {
+                    var creatureMovement = data.Item1;
+                    if (creatureMovement.Waypoints.Count == 0)
+                        continue;
+
+                    string commentInformation = $"GUID: {creatureMovement.GUID} PathType: {creatureMovement.Type}";
+                    output += "-- " + commentInformation + "\n";
+                    output += nodeSql;
+
+                    int pointIdCounter = 1;
+                    int actualPoint = 1;
+                    foreach (var node in creatureMovement.Waypoints)
+                    {
+                        bool finalP = creatureMovement.Destination == null && creatureMovement.Waypoints.Count == actualPoint;
+                        ++actualPoint;
+                        float ori = finalP ? (creatureMovement.FinalOrientation != null ? creatureMovement.FinalOrientation.Value : 100f) : 100f;
+                        if (node.Point == false)
+                        {
+                            if (Settings.SkipIntermediatePoints == true)
+                                continue;
+                            output += "-- ";
+                        }
+                        output += $"(@MOVID + {pathIdCounter}, '{pointIdCounter}', '{node.Position.X}', '{node.Position.Y}', '{node.Position.Z}', '{ori}')";
+
+                        if (!finalP)
+                            output += ",\n";
+                        else
+                            output += ";\n\n";
+
+                        ++pointIdCounter;
+                    }
+
+                    if (creatureMovement.Destination != null)
+                    {
+                        float ori = creatureMovement.FinalOrientation != null ? creatureMovement.FinalOrientation.Value : 100f;
+                        output += $"(@MOVID + {pathIdCounter}, '{pointIdCounter}', '{creatureMovement.Destination.Position.X}', '{creatureMovement.Destination.Position.Y}', '{creatureMovement.Destination.Position.Z}', '{ori}', '0', '0', NULL);\n\n";
+                    }
+
+                    ++pathIdCounter;
+                }
+            }
+
+            return output;
+        }
+    }
+}
diff --git a/WowPacketParser/Store/Objects/Movement/CreatureMovement.cs b/WowPacketParser/Store/Objects/Movement/CreatureMovement.cs
new file mode 100644
index 0000000000..a19fda1ac8
--- /dev/null
+++ b/WowPacketParser/Store/Objects/Movement/CreatureMovement.cs
@@ -0,0 +1,16 @@
+using System.Collections.Generic;
+using WowPacketParser.Misc;
+
+namespace WowPacketParser.Store.Objects.Movement
+{
+    public class CreatureMovement
+    {
+        public CreatureMovementFlags Type { get; set; }
+        public WowGuid GUID { get; set; }
+        public int PathId { get; set; }
+        public int Id { get; set; }
+        public List<CreatureMovementNode> Waypoints { get; set; } = new();
+        public CreatureMovementNode? Destination { get; set; } = null;
+        public float? FinalOrientation { get; set; } = null; // signals end of current path and wait time
+    }
+}
diff --git a/WowPacketParser/Store/Objects/Movement/CreatureMovementFlags.cs b/WowPacketParser/Store/Objects/Movement/CreatureMovementFlags.cs
new file mode 100644
index 0000000000..2934fbd1b6
--- /dev/null
+++ b/WowPacketParser/Store/Objects/Movement/CreatureMovementFlags.cs
@@ -0,0 +1,12 @@
+namespace WowPacketParser.Store.Objects.Movement
+{
+    public enum CreatureMovementFlags
+    {
+        None                    = 0, // pathfinding
+        ExactPath               = 1, // sent fully
+        ExactPathFlying         = 2, // sent fully + flying flag
+        ExactPathFlyingCyclic   = 3, // sent fully + flying flag + cyclic flag
+        ExactPathAndJump        = 4, // sent fully + parabolic movement at the end
+        Invalid                 = 100,            
+    }
+}
diff --git a/WowPacketParser/Store/Objects/Movement/CreatureMovementNode.cs b/WowPacketParser/Store/Objects/Movement/CreatureMovementNode.cs
new file mode 100644
index 0000000000..1dd40323c3
--- /dev/null
+++ b/WowPacketParser/Store/Objects/Movement/CreatureMovementNode.cs
@@ -0,0 +1,10 @@
+using WowPacketParser.Misc;
+
+namespace WowPacketParser.Store.Objects.Movement
+{
+    public class CreatureMovementNode
+    {
+        public Vector3 Position { get; set; }
+        public bool Point { get; set; }
+    }
+}
diff --git a/WowPacketParser/Store/Storage.cs b/WowPacketParser/Store/Storage.cs
index c86707b900..4daaed92e4 100644
--- a/WowPacketParser/Store/Storage.cs
+++ b/WowPacketParser/Store/Storage.cs
@@ -3,6 +3,7 @@
 using WowPacketParser.Enums;
 using WowPacketParser.Misc;
 using WowPacketParser.Store.Objects;
+using WowPacketParser.Store.Objects.Movement;
 
 namespace WowPacketParser.Store
 {
@@ -117,6 +118,9 @@ public static class Storage
         // Weather updates
         public static readonly DataBag<WeatherUpdate> WeatherUpdates = new DataBag<WeatherUpdate>(new List<SQLOutput> { SQLOutput.weather_updates });
 
+        // Movement
+        public static readonly StoreBag<CreatureMovement> CreatureMovement = new StoreBag<CreatureMovement>(new List<SQLOutput> { SQLOutput.creature_movement });
+
         // Npc Spell Click
         public static readonly StoreBag<WowGuid> NpcSpellClicks = new StoreBag<WowGuid>(new List<SQLOutput> { SQLOutput.npc_spellclick_spells });
         public static readonly DataBag<NpcSpellClick> SpellClicks = new DataBag<NpcSpellClick>(new List<SQLOutput> { SQLOutput.npc_spellclick_spells });
diff --git a/WowPacketParserModule.V2_5_1_38707/Parsers/UpdateHandler.cs b/WowPacketParserModule.V2_5_1_38707/Parsers/UpdateHandler.cs
index 4c2d91db4f..08bd569be3 100644
--- a/WowPacketParserModule.V2_5_1_38707/Parsers/UpdateHandler.cs
+++ b/WowPacketParserModule.V2_5_1_38707/Parsers/UpdateHandler.cs
@@ -1,10 +1,13 @@
-using WowPacketParser.Enums;
+using System.Drawing;
+using System.Linq;
+using WowPacketParser.Enums;
 using WowPacketParser.Misc;
 using WowPacketParser.PacketStructures;
 using WowPacketParser.Parsing;
 using WowPacketParser.Proto;
 using WowPacketParser.Store;
 using WowPacketParser.Store.Objects;
+using WowPacketParser.Store.Objects.Movement;
 using WowPacketParser.Store.Objects.UpdateFields;
 using CoreFields = WowPacketParser.Enums.Version;
 using CoreParsers = WowPacketParser.Parsing.Parsers;
@@ -441,14 +444,35 @@ private static MovementInfo ReadMovementUpdateBlock(Packet packet, WowGuid guid,
                 {
                     packet.ResetBitReader();
                     packet.ReadInt32("ID", index);
-                    packet.ReadVector3("Destination", index);
+
+                    CreatureMovement movement = Storage.CreatureMovement.Where(p => p.Item1.GUID == guid).SingleOrDefault()?.Item1;
+                    bool add = false;
+                    if (movement == null)
+                    {
+                        movement = new CreatureMovement()
+                        {
+                            GUID = guid
+                        };
+                        add = true;
+                    }
+
+                    var destination = packet.ReadVector3("Destination", index);
 
                     var hasMovementSplineMove = packet.ReadBit("MovementSplineMove", index);
                     if (hasMovementSplineMove)
                     {
                         packet.ResetBitReader();
 
-                        packet.ReadUInt32E<SplineFlag>("SplineFlags", index);
+                        var splineFlag = packet.ReadUInt32E<SplineFlag>("SplineFlags", index);
+                        CreatureMovementFlags moveType = CreatureMovementFlags.None;
+
+                        if (splineFlag.HasFlag(SplineFlag.EnterCycle) || splineFlag.HasFlag(SplineFlag.Cyclic))
+                            moveType = CreatureMovementFlags.ExactPathFlyingCyclic;
+                        else if (splineFlag.HasFlag(SplineFlag.Flying))
+                            moveType = CreatureMovementFlags.ExactPathFlying;
+                        else if (splineFlag.HasFlag(SplineFlag.UncompressedPath))
+                            moveType = CreatureMovementFlags.ExactPath;
+
                         packet.ReadInt32("Elapsed", index);
                         packet.ReadUInt32("Duration", index);
                         packet.ReadSingle("DurationModifier", index);
@@ -493,6 +517,7 @@ private static MovementInfo ReadMovementUpdateBlock(Packet packet, WowGuid guid,
                                 break;
                             case 3:
                                 orientation = packet.ReadSingle("FaceDirection", index);
+                                moveType = CreatureMovementFlags.Invalid;
                                 break;
                             default:
                                 break;
@@ -504,13 +529,23 @@ private static MovementInfo ReadMovementUpdateBlock(Packet packet, WowGuid guid,
                         for (var i = 0; i < pointsCount; ++i)
                         {
                             var spot = packet.ReadVector3("Points", index, i);
+                            if (moveType != CreatureMovementFlags.Invalid)
+                                movement.Waypoints.Add(new CreatureMovementNode
+                                {
+                                    Position = spot,
+                                    Point = splineFlag.HasFlag(SplineFlag.EnterCycle) || splineFlag.HasFlag(SplineFlag.Cyclic)
+                                });
                         }
 
                         if (hasSpellEffectExtraData)
                             V8_0_1_27101.Parsers.MovementHandler.ReadMonsterSplineSpellEffectExtraData(packet, index);
 
                         if (hasJumpExtraData)
-                            V8_0_1_27101.Parsers.MovementHandler.ReadMonsterSplineJumpExtraData(packet, index);
+                        {
+                            var jumpData = V8_0_1_27101.Parsers.MovementHandler.ReadMonsterSplineJumpExtraData(packet, index);
+                            if (jumpData.StartTime > 0)
+                                moveType = CreatureMovementFlags.ExactPathAndJump;
+                        }
 
                         if (hasAnimationTierTransition)
                         {
@@ -531,6 +566,9 @@ private static MovementInfo ReadMovementUpdateBlock(Packet packet, WowGuid guid,
                             }
                         }
                     }
+
+                    if (movement.Type != CreatureMovementFlags.Invalid && add)
+                        Storage.CreatureMovement.Add(movement);
                 }
             }
 
diff --git a/WowPacketParserModule.V3_4_0_45166/Parsers/MovementHandler.cs b/WowPacketParserModule.V3_4_0_45166/Parsers/MovementHandler.cs
index b26184ada5..3b9626b787 100644
--- a/WowPacketParserModule.V3_4_0_45166/Parsers/MovementHandler.cs
+++ b/WowPacketParserModule.V3_4_0_45166/Parsers/MovementHandler.cs
@@ -8,8 +8,10 @@
 using WowPacketParser.PacketStructures;
 using WowPacketParser.Parsing;
 using WowPacketParser.Proto;
+using WowPacketParser.SQL.Builders;
 using WowPacketParser.Store;
 using WowPacketParser.Store.Objects;
+using WowPacketParser.Store.Objects.Movement;
 using CoreParsers = WowPacketParser.Parsing.Parsers;
 using MovementFlag = WowPacketParser.Enums.v4.MovementFlag;
 using MovementFlag2 = WowPacketParser.Enums.v4.MovementFlag2;
@@ -55,10 +57,21 @@ public static SplineJump ReadMonsterSplineJumpExtraData(Packet packet, params ob
             return jump;
         }
 
-        public static void ReadMovementSpline(Packet packet, Vector3 pos, params object[] indexes)
+        public static void ReadMovementSpline(Packet packet, Vector3 pos, CreatureMovement movement, params object[] indexes)
         {
             PacketMonsterMove monsterMove = packet.Holder.MonsterMove;
-            monsterMove.Flags = packet.ReadUInt32E<SplineFlag>("Flags", indexes).ToUniversal();
+            var splineFlag = packet.ReadUInt32E<SplineFlag>("Flags", indexes);
+            monsterMove.Flags = splineFlag.ToUniversal();
+
+            CreatureMovementFlags moveType = CreatureMovementFlags.None;
+
+            if (splineFlag.HasFlag(SplineFlag.EnterCicle) || splineFlag.HasFlag(SplineFlag.Cyclic))
+                moveType = CreatureMovementFlags.ExactPathFlyingCyclic;
+            else if (splineFlag.HasFlag(SplineFlag.Flying))
+                moveType = CreatureMovementFlags.ExactPathFlying;
+            else if (splineFlag.HasFlag(SplineFlag.UncompressedPath))
+                moveType = CreatureMovementFlags.ExactPath;
+
             if (ClientVersion.RemovedInVersion(ClientType.Shadowlands))
             {
                 packet.ReadByte("AnimTier", indexes);
@@ -109,6 +122,7 @@ public static void ReadMovementSpline(Packet packet, Vector3 pos, params object[
                     SplineLookTarget lookTarget = monsterMove.LookTarget = new();
                     lookTarget.Orientation = packet.ReadSingle("FaceDirection", indexes);
                     lookTarget.Target = packet.ReadPackedGuid128("FacingGUID", indexes);
+                    moveType = CreatureMovementFlags.Invalid;
                     break;
                 case SplineFacingType.Angle:
                     monsterMove.LookOrientation = packet.ReadSingle("FaceDirection", indexes);
@@ -148,7 +162,11 @@ public static void ReadMovementSpline(Packet packet, Vector3 pos, params object[
                 ReadMonsterSplineSpellEffectExtraData(packet, indexes, "MonsterSplineSpellEffectExtra");
 
             if (hasJumpExtraData)
+            {
                 monsterMove.Jump = ReadMonsterSplineJumpExtraData(packet, indexes, "MonsterSplineJumpExtraData");
+                if (monsterMove.Jump.StartTime > 0)
+                    moveType = CreatureMovementFlags.ExactPathAndJump;
+            }
 
             if (hasAnimTier)
             {
@@ -185,19 +203,48 @@ public static void ReadMovementSpline(Packet packet, Vector3 pos, params object[
                     Y = mid.Y - waypoints[i].Y,
                     Z = mid.Z - waypoints[i].Z
                 };
+                if (moveType != CreatureMovementFlags.Invalid)
+                    movement.Waypoints.Add(new CreatureMovementNode
+                    {
+                        Position = vec,
+                        Point = false
+                    });
                 monsterMove.PackedPoints.Add(vec);
                 packet.AddValue("WayPoints", vec, indexes, i);
             }
 
+            if (moveType != CreatureMovementFlags.Invalid)
+                foreach (var point in monsterMove.Points)
+                    movement.Waypoints.Add(new CreatureMovementNode
+                    {
+                        Position = point,
+                        Point = true
+                    });
+
             float moveTimeInSec = (float)monsterMove.MoveTime / 1000;
             float speedXY = (float)overallDist / moveTimeInSec;
             packet.AddValue("CalculatedSpeedXY", speedXY, indexes);
+            if (moveType != CreatureMovementFlags.Invalid)
+                movement.Type |= moveType;
         }
 
         public static void ReadMovementMonsterSpline(Packet packet, Vector3 pos, params object[] indexes)
         {
             PacketMonsterMove monsterMove = packet.Holder.MonsterMove;
             monsterMove.Id = packet.ReadUInt32("Id", indexes);
+
+            var guid = new WowGuid128(monsterMove.Mover.Guid128.Low, monsterMove.Mover.Guid128.High);
+            CreatureMovement movement = Storage.CreatureMovement.Where(p => p.Item1.GUID == guid).SingleOrDefault()?.Item1;
+            bool add = false;
+            if (movement == null)
+            {
+                movement = new CreatureMovement()
+                {
+                    GUID = guid
+                };
+                add = true;
+            }
+
             if (ClientVersion.RemovedInVersion(ClientBranch.Classic, ClientVersionBuild.V1_15_0_52146) || ClientVersion.Branch != ClientBranch.Classic)
                 monsterMove.Destination = packet.ReadVector3("Destination", indexes);
 
@@ -206,7 +253,10 @@ public static void ReadMovementMonsterSpline(Packet packet, Vector3 pos, params
             packet.ReadBit("CrzTeleport", indexes);
             packet.ReadBits("StopDistanceTolerance", 3, indexes);
 
-            ReadMovementSpline(packet, pos, indexes, "MovementSpline");
+            ReadMovementSpline(packet, pos, movement, indexes, "MovementSpline");
+
+            if (movement.Type != CreatureMovementFlags.Invalid && add)
+                Storage.CreatureMovement.Add(movement);
         }
 
         [Parser(Opcode.SMSG_LOGIN_SET_TIME_SPEED)]
diff --git a/WowPacketParserModule.V8_0_1_27101/Parsers/MovementHandler.cs b/WowPacketParserModule.V8_0_1_27101/Parsers/MovementHandler.cs
index aaac430d2a..80458027a4 100644
--- a/WowPacketParserModule.V8_0_1_27101/Parsers/MovementHandler.cs
+++ b/WowPacketParserModule.V8_0_1_27101/Parsers/MovementHandler.cs
@@ -6,6 +6,9 @@
 using WowPacketParser.Misc;
 using WowPacketParser.Parsing;
 using WowPacketParser.Proto;
+using WowPacketParser.Store;
+using WowPacketParser.Store.Objects.Movement;
+using WowPacketParserModule.V6_0_2_19033.Parsers;
 using WowPacketParserModule.V7_0_3_22248.Enums;
 using CoreParsers = WowPacketParser.Parsing.Parsers;
 using SplineFacingType = WowPacketParserModule.V6_0_2_19033.Enums.SplineFacingType;
@@ -51,10 +54,21 @@ public static SplineJump ReadMonsterSplineJumpExtraData(Packet packet, params ob
             return jump;
         }
 
-        public static void ReadMovementSpline(Packet packet, Vector3 pos, params object[] indexes)
+        public static void ReadMovementSpline(Packet packet, Vector3 pos, CreatureMovement movement, params object[] indexes)
         {
             PacketMonsterMove monsterMove = packet.Holder.MonsterMove;
-            monsterMove.Flags = packet.ReadUInt32E<SplineFlag>("Flags", indexes).ToUniversal();
+            var splineFlag = packet.ReadUInt32E<SplineFlag>("Flags", indexes);
+            monsterMove.Flags = splineFlag.ToUniversal();
+
+            CreatureMovementFlags moveType = CreatureMovementFlags.None;
+
+            if (splineFlag.HasFlag(SplineFlag.EnterCycle) || splineFlag.HasFlag(SplineFlag.Cyclic))
+                moveType = CreatureMovementFlags.ExactPathFlyingCyclic;
+            else if (splineFlag.HasFlag(SplineFlag.Flying))
+                moveType = CreatureMovementFlags.ExactPathFlying;
+            else if (splineFlag.HasFlag(SplineFlag.UncompressedPath))
+                moveType = CreatureMovementFlags.ExactPath;
+
             if (ClientVersion.RemovedInVersion(ClientType.Shadowlands))
             {
                 packet.ReadByte("AnimTier", indexes);
@@ -105,9 +119,11 @@ public static void ReadMovementSpline(Packet packet, Vector3 pos, params object[
                     SplineLookTarget lookTarget = monsterMove.LookTarget = new();
                     lookTarget.Orientation = packet.ReadSingle("FaceDirection", indexes);
                     lookTarget.Target = packet.ReadPackedGuid128("FacingGUID", indexes);
+                    moveType = CreatureMovementFlags.Invalid;
                     break;
                 case SplineFacingType.Angle:
                     monsterMove.LookOrientation = packet.ReadSingle("FaceDirection", indexes);
+                    movement.FinalOrientation = monsterMove.LookOrientation;
                     break;
                 default:
                     break;
@@ -144,7 +160,11 @@ public static void ReadMovementSpline(Packet packet, Vector3 pos, params object[
                 ReadMonsterSplineSpellEffectExtraData(packet, indexes, "MonsterSplineSpellEffectExtra");
 
             if (hasJumpExtraData)
+            {
                 monsterMove.Jump = ReadMonsterSplineJumpExtraData(packet, indexes, "MonsterSplineJumpExtraData");
+                if (monsterMove.Jump.StartTime > 0)
+                    moveType = CreatureMovementFlags.ExactPathAndJump;
+            }
 
             if (hasAnimTier)
             {
@@ -181,38 +201,76 @@ public static void ReadMovementSpline(Packet packet, Vector3 pos, params object[
                     Y = mid.Y - waypoints[i].Y,
                     Z = mid.Z - waypoints[i].Z
                 };
+                if (moveType != CreatureMovementFlags.Invalid)
+                    movement.Waypoints.Add(new CreatureMovementNode
+                    {
+                        Position = vec,
+                        Point = false
+                    });
                 monsterMove.PackedPoints.Add(vec);
                 packet.AddValue("WayPoints", vec, indexes, i);
             }
 
+            if (moveType != CreatureMovementFlags.Invalid)
+                foreach (var point in monsterMove.Points)
+                    movement.Waypoints.Add(new CreatureMovementNode
+                    {
+                        Position = point,
+                        Point = true
+                    });
+
             float moveTimeInSec = (float)monsterMove.MoveTime / 1000;
             float speedXY = (float)overallDist / moveTimeInSec;
             packet.AddValue("CalculatedSpeedXY", speedXY, indexes);
+            if (moveType != CreatureMovementFlags.Invalid)
+                movement.Type |= moveType;
         }
 
-        public static void ReadMovementMonsterSpline(Packet packet, Vector3 pos, params object[] indexes)
+        public static void ReadMovementMonsterSpline(Packet packet, Vector3 pos, WowGuid guid, params object[] indexes)
         {
             PacketMonsterMove monsterMove = packet.Holder.MonsterMove;
+            CreatureMovement movement = Storage.CreatureMovement.Where(p => p.Item1.GUID == guid).SingleOrDefault()?.Item1;
+            bool add = false;
+            if (movement == null)
+            {
+                movement = new CreatureMovement()
+                {
+                    GUID = guid
+                };
+                add = true;
+            }
             monsterMove.Id = packet.ReadUInt32("Id", indexes);
             if (ClientVersion.RemovedInVersion(ClientBranch.Retail, ClientVersionBuild.V10_2_0_52038) || ClientVersion.Branch != ClientBranch.Retail)
-                monsterMove.Destination = packet.ReadVector3("Destination", indexes);
+            {
+                var destination = packet.ReadVector3("Destination", indexes);
+                monsterMove.Destination = destination;
+                if (destination.X != 0 || destination.Y != 0 || destination.Z != 0)
+                {
+                    movement.Destination = new CreatureMovementNode();
+                    movement.Destination.Position = destination;
+                }
+            }
 
             packet.ResetBitReader();
 
             packet.ReadBit("CrzTeleport", indexes);
             packet.ReadBits("StopDistanceTolerance", 3, indexes);
 
-            ReadMovementSpline(packet, pos, indexes, "MovementSpline");
+            ReadMovementSpline(packet, pos, movement, indexes, "MovementSpline");
+
+            if (movement.Type != CreatureMovementFlags.Invalid && add)
+                Storage.CreatureMovement.Add(movement);
         }
 
         [Parser(Opcode.SMSG_ON_MONSTER_MOVE)]
         public static void HandleOnMonsterMove(Packet packet)
         {
             PacketMonsterMove monsterMove = packet.Holder.MonsterMove = new();
-            monsterMove.Mover = packet.ReadPackedGuid128("MoverGUID");
+            var moverGuid = packet.ReadPackedGuid128("MoverGUID");
+            monsterMove.Mover = moverGuid;
             Vector3 pos = monsterMove.Position = packet.ReadVector3("Position");
 
-            ReadMovementMonsterSpline(packet, pos, "MovementMonsterSpline");
+            ReadMovementMonsterSpline(packet, pos, moverGuid, "MovementMonsterSpline");
         }
 
         [Parser(Opcode.SMSG_PHASE_SHIFT_CHANGE)]

From 81aebf49899d1b9b13a8b2dba6558d9bc7d764de Mon Sep 17 00:00:00 2001
From: killerwife <killerwife@gmail.com>
Date: Sat, 9 Nov 2024 16:30:58 +0100
Subject: [PATCH 3/5] Add cata waypoint gen

---
 .../Parsers/MovementHandler.cs                | 63 +++++++++++++++++--
 1 file changed, 58 insertions(+), 5 deletions(-)

diff --git a/WowPacketParserModule.V4_4_0_54481/Parsers/MovementHandler.cs b/WowPacketParserModule.V4_4_0_54481/Parsers/MovementHandler.cs
index a80f91b0dc..20e5054db9 100644
--- a/WowPacketParserModule.V4_4_0_54481/Parsers/MovementHandler.cs
+++ b/WowPacketParserModule.V4_4_0_54481/Parsers/MovementHandler.cs
@@ -8,6 +8,9 @@
 using WowPacketParser.Misc;
 using WowPacketParser.Parsing;
 using WowPacketParser.Proto;
+using WowPacketParser.SQL.Builders;
+using WowPacketParser.Store;
+using WowPacketParser.Store.Objects.Movement;
 using WowPacketParserModule.V7_0_3_22248.Enums;
 using CoreParsers = WowPacketParser.Parsing.Parsers;
 using SplineFacingType = WowPacketParserModule.V6_0_2_19033.Enums.SplineFacingType;
@@ -153,10 +156,21 @@ public static void ReadMonsterSplineFilter(Packet packet, params object[] indexe
             packet.ReadBits("FilterFlags", 2, indexes);
         }
 
-        public static void ReadMovementSpline(Packet packet, Vector3 pos, params object[] indexes)
+        public static void ReadMovementSpline(Packet packet, Vector3 pos, CreatureMovement movement, params object[] indexes)
         {
             PacketMonsterMove monsterMove = packet.Holder.MonsterMove;
-            monsterMove.Flags = packet.ReadUInt32E<SplineFlag>("Flags", indexes).ToUniversal();
+            var splineFlag = packet.ReadUInt32E<SplineFlag>("Flags", indexes);
+            monsterMove.Flags = splineFlag.ToUniversal();
+
+            CreatureMovementFlags moveType = CreatureMovementFlags.None;
+
+            if (splineFlag.HasFlag(SplineFlag.EnterCycle) || splineFlag.HasFlag(SplineFlag.Cyclic))
+                moveType = CreatureMovementFlags.ExactPathFlyingCyclic;
+            else if (splineFlag.HasFlag(SplineFlag.Flying))
+                moveType = CreatureMovementFlags.ExactPathFlying;
+            else if (splineFlag.HasFlag(SplineFlag.UncompressedPath))
+                moveType = CreatureMovementFlags.ExactPath;
+
             monsterMove.ElapsedTime = packet.ReadInt32("Elapsed", indexes);
             monsterMove.MoveTime = packet.ReadUInt32("MoveTime", indexes);
             packet.ReadUInt32("FadeObjectTime", indexes);
@@ -189,6 +203,7 @@ public static void ReadMovementSpline(Packet packet, Vector3 pos, params object[
                     SplineLookTarget lookTarget = monsterMove.LookTarget = new();
                     lookTarget.Orientation = packet.ReadSingle("FaceDirection", indexes);
                     lookTarget.Target = packet.ReadPackedGuid128("FacingGUID", indexes);
+                    moveType = CreatureMovementFlags.Invalid;
                     break;
                 case SplineFacingType.Angle:
                     monsterMove.LookOrientation = packet.ReadSingle("FaceDirection", indexes);
@@ -228,7 +243,11 @@ public static void ReadMovementSpline(Packet packet, Vector3 pos, params object[
                 ReadMonsterSplineSpellEffectExtraData(packet, indexes, "MonsterSplineSpellEffectExtra");
 
             if (hasJumpExtraData)
+            {
                 monsterMove.Jump = ReadMonsterSplineJumpExtraData(packet, indexes, "MonsterSplineJumpExtraData");
+                if (monsterMove.Jump.StartTime > 0)
+                    moveType = CreatureMovementFlags.ExactPathAndJump;
+            }
 
             if (hasAnimTier)
             {
@@ -256,14 +275,32 @@ public static void ReadMovementSpline(Packet packet, Vector3 pos, params object[
                 };
                 monsterMove.PackedPoints.Add(vec);
                 packet.AddValue("WayPoints", vec, indexes, i);
+
+                if (moveType != CreatureMovementFlags.Invalid)
+                    movement.Waypoints.Add(new CreatureMovementNode
+                    {
+                        Position = vec,
+                        Point = false
+                    });
             }
 
+            if (moveType != CreatureMovementFlags.Invalid)
+                foreach (var point in monsterMove.Points)
+                    movement.Waypoints.Add(new CreatureMovementNode
+                    {
+                        Position = point,
+                        Point = true
+                    });
+
             float moveTimeInSec = (float)monsterMove.MoveTime / 1000;
             float speedXY = (float)overallDist / moveTimeInSec;
             packet.AddValue("CalculatedSpeedXY", speedXY, indexes);
+
+            if (moveType != CreatureMovementFlags.Invalid)
+                movement.Type |= moveType;
         }
 
-        public static void ReadMovementMonsterSpline(Packet packet, Vector3 pos, params object[] indexes)
+        public static void ReadMovementMonsterSpline(Packet packet, Vector3 pos, CreatureMovement movement, params object[] indexes)
         {
             PacketMonsterMove monsterMove = packet.Holder.MonsterMove;
             monsterMove.Id = packet.ReadUInt32("Id", indexes);
@@ -272,7 +309,7 @@ public static void ReadMovementMonsterSpline(Packet packet, Vector3 pos, params
             packet.ReadBit("CrzTeleport", indexes);
             packet.ReadBits("StopDistanceTolerance", 3, indexes);
 
-            ReadMovementSpline(packet, pos, indexes, "MovementSpline");
+            ReadMovementSpline(packet, pos, movement, indexes, "MovementSpline");
         }
 
         public static void ReadVignetteData(Packet packet, params object[] idx)
@@ -389,10 +426,26 @@ public static void HandleAdjustSplineDuration(Packet packet)
         public static void HandleOnMonsterMove(Packet packet)
         {
             PacketMonsterMove monsterMove = packet.Holder.MonsterMove = new();
+
             monsterMove.Mover = packet.ReadPackedGuid128("MoverGUID");
             Vector3 pos = monsterMove.Position = packet.ReadVector3("Position");
 
-            ReadMovementMonsterSpline(packet, pos, "MovementMonsterSpline");
+            var guid = new WowGuid128(monsterMove.Mover.Guid128.Low, monsterMove.Mover.Guid128.High);
+            CreatureMovement movement = Storage.CreatureMovement.Where(p => p.Item1.GUID == guid).SingleOrDefault()?.Item1;
+            bool add = false;
+            if (movement == null)
+            {
+                movement = new CreatureMovement()
+                {
+                    GUID = guid
+                };
+                add = true;
+            }
+
+            ReadMovementMonsterSpline(packet, pos, movement, "MovementMonsterSpline");
+
+            if (movement.Type != CreatureMovementFlags.Invalid && add)
+                Storage.CreatureMovement.Add(movement);
         }
 
         [Parser(Opcode.SMSG_BIND_POINT_UPDATE)]

From 25cd67f339eaa2100d9914307c465c6abc3c0bd7 Mon Sep 17 00:00:00 2001
From: killerwife <killerwife@gmail.com>
Date: Sat, 9 Nov 2024 19:59:01 +0100
Subject: [PATCH 4/5] Fix update object destination missing from wps

---
 WowPacketParserModule.V2_5_1_38707/Parsers/UpdateHandler.cs | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/WowPacketParserModule.V2_5_1_38707/Parsers/UpdateHandler.cs b/WowPacketParserModule.V2_5_1_38707/Parsers/UpdateHandler.cs
index 08bd569be3..bf0be50b38 100644
--- a/WowPacketParserModule.V2_5_1_38707/Parsers/UpdateHandler.cs
+++ b/WowPacketParserModule.V2_5_1_38707/Parsers/UpdateHandler.cs
@@ -457,6 +457,11 @@ private static MovementInfo ReadMovementUpdateBlock(Packet packet, WowGuid guid,
                     }
 
                     var destination = packet.ReadVector3("Destination", index);
+                    movement.Waypoints.Add(new CreatureMovementNode
+                    {
+                        Position = destination,
+                        Point = true
+                    });
 
                     var hasMovementSplineMove = packet.ReadBit("MovementSplineMove", index);
                     if (hasMovementSplineMove)

From 3a04fed48fb1e18b1277b4361a267663729dc38a Mon Sep 17 00:00:00 2001
From: killerwife <killerwife@gmail.com>
Date: Sat, 9 Nov 2024 20:19:35 +0100
Subject: [PATCH 5/5] Fix config naming for SkipIntermediatePoints

---
 WowPacketParser/Misc/Settings.cs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/WowPacketParser/Misc/Settings.cs b/WowPacketParser/Misc/Settings.cs
index 7f454ce9b7..4107e8359a 100644
--- a/WowPacketParser/Misc/Settings.cs
+++ b/WowPacketParser/Misc/Settings.cs
@@ -32,7 +32,7 @@ public static class Settings
         public static readonly bool ForcePhaseZero = Conf.GetBoolean("ForcePhaseZero", false);
         public static readonly bool GenerateCreateObject2SpawnsOnly = Conf.GetBoolean("GenerateCreateObject2SpawnsOnly", false);
         public static readonly bool SkipDuplicateSpawns = Conf.GetBoolean("SkipDuplicateSpawns", false);
-        public static readonly bool SkipIntermediatePoints = Conf.GetBoolean("SkipDuplicateSpawns", false);
+        public static readonly bool SkipIntermediatePoints = Conf.GetBoolean("SkipIntermediatePoints", false);
         public static readonly string SQLFileName = Conf.GetString("SQLFileName", string.Empty);
         public static readonly bool SplitSQLFile = Conf.GetBoolean("SplitSQLFile", false);
         public static readonly bool ShowEndPrompt = Conf.GetBoolean("ShowEndPrompt", false);