Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GRUB for SL specification and push changes to TrenchBoot GRUB repository #32

Closed
BeataZdunczyk opened this issue Jul 5, 2024 · 2 comments
Assignees
Labels
P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. T: task Type: task. An action item that is neither a bug nor an enhancement. W: todo Workflow: todo. The issue is in the initial to do state.

Comments

@BeataZdunczyk
Copy link
Member

Brief summary
A clear and concise summary of the task that should be done.

The existing AMD support was designed and implemented before the Secure Launch (SL) specification was defined. Therefore, changes are required in GRUB to use the structures expected by the SL specification. These changes will align GRUB with the SL structures and be pushed to the GRUB repository.

@BeataZdunczyk BeataZdunczyk added T: task Type: task. An action item that is neither a bug nor an enhancement. P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. W: todo Workflow: todo. The issue is in the initial to do state. labels Jul 5, 2024
@SergiiDmytruk
Copy link
Member

The prospect of loading Linux using AMD SKINIT was taken into account while implementing #17 (initial switch to SLRT for loading Xen via Multiboot2 using Intel TXT) and then #21 (loading Xen via Multiboot2 using AMD SKINIT). Thanks to that preparation code changes made for #31 already follow the latest SL specification.

As demonstrated by comments in that issue (#31 (comment), #31 (comment)), GRUB is capable of starting SKL that uses SLRT (main changes for that are in TrenchBoot/secure-kernel-loader#15) and SKL successfully parses SLRT to extract information about the bootloader (GRUB2) and DLME (Linux).

@krystian-hebel
Copy link
Member

#31 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. T: task Type: task. An action item that is neither a bug nor an enhancement. W: todo Workflow: todo. The issue is in the initial to do state.
Projects
None yet
Development

No branches or pull requests

3 participants