Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use curated MONDO mappings where possible #301

Open
cmungall opened this issue Nov 7, 2024 · 1 comment
Open

Use curated MONDO mappings where possible #301

cmungall opened this issue Nov 7, 2024 · 1 comment

Comments

@cmungall
Copy link

cmungall commented Nov 7, 2024

MONDO has rich mappings using SSSOM

dyskeratosis congenita, autosomal dominant 6
http://purl.obolibrary.org/obo/MONDO_0014690

Here we see mappings to DOID:0070023, OMIM:616553, and others
image

unfortunately this doesn't make it's way into NN

the DOID is a singleton

✗ curl -L -s "https://nodenormalization-sri.renci.org:443/1.4/get_normalized_nodes?curie=DOID%3A0070023&conflate=true" | jq .
{
  "DOID:0070023": {
    "id": {
      "identifier": "DOID:0070023",
      "label": "autosomal dominant dyskeratosis congenita 6"
    },
    "equivalent_identifiers": [
      {
        "identifier": "DOID:0070023",
        "label": "autosomal dominant dyskeratosis congenita 6"
      }
    ],
    "type": [
      "biolink:Disease",
      "biolink:DiseaseOrPhenotypicFeature",
      "biolink:BiologicalEntity",
      "biolink:ThingWithTaxon",
      "biolink:NamedThing"
    ]
  }
}

the Mondo is a singleton:

✗ curl -L -s "https://nodenormalization-sri.renci.org:443/1.4/get_normalized_nodes?curie=MONDO%3A0014690&conflate=false" | jq .
{
  "MONDO:0014690": {
    "id": {
      "identifier": "MONDO:0014690",
      "label": "dyskeratosis congenita, autosomal dominant 6"
    },
    "equivalent_identifiers": [
      {
        "identifier": "MONDO:0014690",
        "label": "dyskeratosis congenita, autosomal dominant 6"
      }
    ],
    "type": [
      "biolink:Disease",
      "biolink:DiseaseOrPhenotypicFeature",
      "biolink:BiologicalEntity",
      "biolink:ThingWithTaxon",
      "biolink:NamedThing"
    ],
    "information_content": 100
  }
}

the OMIM has one NCIT, and 2 UMLSs, one of which is wrong!!!

✗ curl -L -s "https://nodenormalization-sri.renci.org:443/1.4/get_normalized_nodes?curie=OMIM:616553&conflate=false" | jq .
{
  "OMIM:616553": {
    "id": {
      "identifier": "OMIM:616553",
      "label": "DYSKERATOSIS CONGENITA, AUTOSOMAL RECESSIVE 7"
    },
    "equivalent_identifiers": [
      {
        "identifier": "OMIM:616553"
      },
      {
        "identifier": "UMLS:C4225283",
        "label": "DYSKERATOSIS CONGENITA, AUTOSOMAL RECESSIVE 7"
      },
      {
        "identifier": "UMLS:C4225284",
        "label": "DYSKERATOSIS CONGENITA, AUTOSOMAL DOMINANT 6"
      },
      {
        "identifier": "NCIT:C176924",
        "label": "Dyskeratosis Congenita, Autosomal Dominant 6"
      }
    ],
    "type": [
      "biolink:Disease",
      "biolink:DiseaseOrPhenotypicFeature",
      "biolink:BiologicalEntity",
      "biolink:ThingWithTaxon",
      "biolink:NamedThing"
    ],
    "information_content": 100
  }
}

mapping is hard but for disease it's all done to high quality!

@cmungall
Copy link
Author

cmungall commented Nov 8, 2024

May be related:

TranslatorSRI/Babel#369

apologies if I got the wrong tracker!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant