Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes/reports resources #48

Open
wants to merge 4 commits into
base: next
Choose a base branch
from
Open

Fixes/reports resources #48

wants to merge 4 commits into from

Conversation

TsimurSh
Copy link
Contributor

@TsimurSh TsimurSh commented Oct 18, 2024 •
edited
Loading

Fix implementation for report endpoints

  • Fixed hibernate criteria in routeScheduleAdherenceSummary method.
  • Clean up PredictionAccuracyQuery.java
  • Fixed logic for parsing parameters and clean up code.

Contribution Checklist:

  • [ x] The pull request only addresses one issue or adds one feature.
  • [ x] The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • [ x] Create an issue and link to the pull request.

@vesavlad Could you explain how to run or use PredictionAccuracyModule?

@TsimurSh TsimurSh added the bug Something isn't working label Oct 18, 2024
@TsimurSh TsimurSh requested a review from vesavlad October 18, 2024 14:30
@TsimurSh TsimurSh self-assigned this Oct 18, 2024
@TsimurSh TsimurSh linked an issue Oct 18, 2024 that may be closed by this pull request
PredictionAccuracy module fails to load #49
Open
@vesavlad
Copy link
Member

@TsimurSh please check the rework on the ScheduleAdherenceController to see how

 private final WebProperties webProperties;

shall be used

@TsimurSh
Copy link
Contributor Author

TsimurSh commented Dec 9, 2024

@vesavlad Yes, I forgot about properties. Could we merge and close this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vesavlad vesavlad Awaiting requested review from vesavlad

Assignees

@TsimurSh TsimurSh

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PredictionAccuracy module fails to load
2 participants
@TsimurSh @vesavlad