Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better documentation #24

Open
gabrielodom opened this issue Jun 1, 2022 · 5 comments
Open

Better documentation #24

gabrielodom opened this issue Jun 1, 2022 · 5 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@gabrielodom
Copy link
Member

Despite the volume of documented functions, the documentation itself is Don't RY in places where we need repetition and Do RY in places we don't. I need a fresh pair of eyes to look at this package documentation and tell me what places don't have the right documentation, and what places have superfluous or extraneous documentation.

@gabrielodom gabrielodom added the documentation Improvements or additions to documentation label Jun 1, 2022
@gabrielodom gabrielodom self-assigned this Jun 1, 2022
@gabrielodom
Copy link
Member Author

One example: we know that the CoMethAllRegions() function calculates leave-one-out probe correlations, but this isn't actually stated anywhere except in CreateRdrop() (which is like 4-5 function calls deep). Even worse: we don't mention how the correlations between a single probe and all other probes in the region are found (we take the row mean for the other probes, but that's not mentioned anywhere).

@gabrielodom
Copy link
Member Author

Also in CoMethAllRegions(), the the default value for output is CpGs (which is correct), but maybe we need to write a function that will extract the CpGs just in case the user selected dataframe. A simple map() call won't work, because it ignores which CpGs pass the rDrop threshold and should be kept.

@DarioS
Copy link

DarioS commented Jul 25, 2022

Could you add some discussion of tissue analysis versus cell line analysis to the F.A.Q.? For example, if a data set has a sample that is 80% cancer cells and another sample that is 20% cancer cells, correlations may be induced simply by differences of cell type proportions from one sample to the next, rather than the addition or removal of a methyl group from a cytosine (what most people are looking for but often don't realise that the data which they have generated does not suit their question).

@gabrielodom
Copy link
Member Author

@lxw391 do you have thoughts on this? Can we discuss it?

@lxw391
Copy link
Member

lxw391 commented Aug 6, 2022

@DarioS @gabrielodom It's a good suggestion. coMethDMR is flexible and the linear models in coMethDMR can include additional covariate variables to adjust differences in cell type proportions. For blood sample analysis, we can include estimated proportions of different types of cells (via R package such as EpiDish) as covariate variables in the linear model. If the cell type proportions can not be estimated, alternatively you can also use the sva R package to estimate surrogate variables that captures cellular composition. Hope this helps!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants