Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up the code #19

Open
gabrielodom opened this issue Mar 29, 2022 · 2 comments
Open

Clean up the code #19

gabrielodom opened this issue Mar 29, 2022 · 2 comments
Assignees
@gabrielodom
Labels
bug Something isn't working enhancement New feature or request

Comments

@gabrielodom
Copy link
Member

When Lissette and I first wrote this code (circa 2017-2018), I was a baby. Some of this code is gross. This isn't an issue that will probably ever be closed, but I'll be able to reference it as I'm working on other issues.
@gabrielodom gabrielodom added the enhancement New feature or request label Mar 29, 2022
@gabrielodom gabrielodom self-assigned this Mar 29, 2022
gabrielodom added a commit that referenced this issue Mar 29, 2022
@gabrielodom
Code cleaning; see Issue #19
ad1f46b
@gabrielodom gabrielodom added the bug Something isn't working label Mar 29, 2022
@gabrielodom
Copy link
Member Author

The CpGInfo*() functions were missing the argument for genome.

gabrielodom added a commit that referenced this issue Mar 29, 2022
@gabrielodom
See Issue #14, Issue #18, Issue #19
f6a2a8f
@gabrielodom
Copy link
Member Author

We've added the genome argument now.

gabrielodom added a commit that referenced this issue Mar 29, 2022
@gabrielodom
Check time dropped 30% (about 23 minutes to about 15 minutes), so the…
02e5644 
…se changes are helping. Changes per Issue #14; also see Issue #19
gabrielodom added a commit that referenced this issue Mar 29, 2022
@gabrielodom
Making progress on Issue #14; also related to Issue #18 and Issue #19
77522f6
gabrielodom added a commit that referenced this issue Mar 29, 2022
@gabrielodom
I think this is all we need for Issue #14; more edits per Issue #18 a…
b3bc8c0 
…nd Issue #19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gabrielodom gabrielodom

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gabrielodom