Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better support for logical outcomes #17

Open
gabrielodom opened this issue Mar 18, 2022 · 0 comments
Open

Add better support for logical outcomes #17

gabrielodom opened this issue Mar 18, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@gabrielodom
Copy link
Member

I ran some bootstrap samples, and the Type I error is preserved even if we supply a binary outcome as our "continuous phenotype". This is because we invert the test, and put the outcome on the RHS of the model (the methylation has always been on the LHS). However, we coded this assuming that the phenotype would always be continuous. So now, I have to make sure to transform any binary phenotypes to numeric in R first.

Adding support for other categorical outcomes is also mathematically valid, but would be more challenging to implement.

@gabrielodom gabrielodom added the enhancement New feature or request label Mar 18, 2022
@gabrielodom gabrielodom self-assigned this Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant