Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

32 bit floating point support #37

Open
haraldk opened this issue Nov 8, 2024 · 1 comment
Open

32 bit floating point support #37

haraldk opened this issue Nov 8, 2024 · 1 comment

Comments

@haraldk
Copy link

haraldk commented Nov 8, 2024

Hi again, I've been testing the decoder on a lot of images, and I have found an image that won't decode. It's one of the images from the libjxl conformance tests, containing a lossless encoded 32 bit float image:

lossless_pfm/input.jxl

com.traneptora.jxlatte.io.InvalidBitstreamException: Illegal final modular state
	at com.traneptora.jxlatte.frame.modular.ModularStream.decodeChannels(ModularStream.java:196)
	at com.traneptora.jxlatte.frame.modular.ModularStream.decodeChannels(ModularStream.java:184)
	at com.traneptora.jxlatte.frame.group.PassGroup.<init>(PassGroup.java:79)
	at com.traneptora.jxlatte.frame.Frame.decodePassGroups(Frame.java:342)
	at com.traneptora.jxlatte.frame.Frame.decodeFrame(Frame.java:429)
	at com.traneptora.jxlatte.JXLCodestreamDecoder.decode(JXLCodestreamDecoder.java:761)
	at com.traneptora.jxlatte.JXLCodestreamDecoder.decode(JXLCodestreamDecoder.java:686)
	at com.traneptora.jxlatte.JXLDecoder.decode(JXLDecoder.java:41)

This is the only sample file I have come across that actually contains 32 bit and float samples, so I guess they are quite rare. But it would be nice if it could be decoded!

Not sure if this counts as a bug or a new feature... Let me know if I can help fixing this, but I'm afraid my knowledge on JPEG XL is a bit limited at the moment. 😀

@Traneptora
Copy link
Owner

This is most likely an issue with the weighted predictor, upon further investigation. It may require some deeper looking though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants