Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary document file #1387

Open
aleksdmladenovic opened this issue Oct 3, 2024 · 1 comment · May be fixed by #1388
Open

Remove unnecessary document file #1387

aleksdmladenovic opened this issue Oct 3, 2024 · 1 comment · May be fixed by #1388

Comments

@aleksdmladenovic
Copy link
Contributor

This file is not used in our documentation but it exists in docs directory.

https://github.com/TraceMachina/nativelink/blob/main/web/platform/src/content/docs/docs/introduction/contributors.mdx

That file, introduction/contributors is not referenced in starlight.conf.ts either.

{
label: "Getting Started",
collapsed: true,
items: [
{
label: "Introduction",
link: `${docsRoot}/introduction/setup`,
},
{
label: "NativeLink On-Prem",
link: `${docsRoot}/introduction/on-prem`,
},
{
label: "Other Build Systems",
link: `${docsRoot}/introduction/non-bre`,
},
],
},

That file's content also doesn't make sense and it even includes typo of started to starget.

description: "Get starget with NativeLink"

I think that file is created temporarily while development but not removed after we no longer needed that one.

@aleksdmladenovic aleksdmladenovic linked a pull request Oct 3, 2024 that will close this issue
6 tasks
@aleksdmladenovic
Copy link
Contributor Author

Check this issue and PR plz. Thanks.

cc: @allada, @MarcusSorealheis, @blakehatch, @SchahinRohani

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant