From 8670290bc8e28fffa3cadcbbfba2b00145575255 Mon Sep 17 00:00:00 2001 From: Aaron Siddhartha Mondal Date: Sun, 15 Dec 2024 00:18:34 +0100 Subject: [PATCH] Fix hardcoded value in local-image-test --- tools/public/local-image-test.nix | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/tools/public/local-image-test.nix b/tools/public/local-image-test.nix index 4733e9c10..b87658563 100644 --- a/tools/public/local-image-test.nix +++ b/tools/public/local-image-test.nix @@ -16,13 +16,15 @@ writeShellScriptBin "local-image-test" '' IMAGE_TAG=$(nix eval .#$1.imageTag --raw) IMAGE_NAME=$(nix eval .#$1.imageName --raw) - nix run .#image.copyTo \ + nix run .#$1.copyTo \ docker-daemon:''${IMAGE_NAME}:''${IMAGE_TAG} # Ensure that the image has minimal closure size. + # TODO(aaronmondal): The default allows 10% inefficiency. Since we control all + # our images fully we should enforce 0% inefficiency. At + # the moment this breaks lre-cc. CI=1 ${dive}/bin/dive \ - ''${IMAGE_NAME}:''${IMAGE_TAG} \ - --highestWastedBytes=0 + ''${IMAGE_NAME}:''${IMAGE_TAG} # TODO(aaronmondal): Keep monitoring this for better solutions to ratelimits: # https://github.com/aquasecurity/trivy-action/issues/389