From 7b050ef96e3b76dfbfd6413bfe2404ac28861f03 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mateusz=20Kope=C4=87?= Date: Wed, 18 Dec 2024 15:40:07 +0100 Subject: [PATCH] Integer dictionary support in fragment inputs (#7341) --- .../fragment-input-definition/item/types.ts | 1 + .../validation/PrettyValidationErrors.scala | 9 ++++---- .../ui/api/DictApiHttpServiceSpec.scala | 21 ++++++++++++++--- docs/Changelog.md | 1 + .../sample/DevProcessConfigCreator.scala | 1 + .../sample/dict/IntegerDictionary.scala | 23 +++++++++++++++++++ .../FragmentParameterValidator.scala | 6 +++-- 7 files changed, 53 insertions(+), 9 deletions(-) create mode 100644 engine/flink/management/dev-model/src/main/scala/pl/touk/nussknacker/engine/management/sample/dict/IntegerDictionary.scala diff --git a/designer/client/src/components/graph/node-modal/fragment-input-definition/item/types.ts b/designer/client/src/components/graph/node-modal/fragment-input-definition/item/types.ts index 212f8e743f3..9f960b9603b 100644 --- a/designer/client/src/components/graph/node-modal/fragment-input-definition/item/types.ts +++ b/designer/client/src/components/graph/node-modal/fragment-input-definition/item/types.ts @@ -86,6 +86,7 @@ export function isPermittedTypeVariant(item: FragmentInputParameter): item is Pe resolveRefClazzName(item.typ.refClazzName) === "String", resolveRefClazzName(item.typ.refClazzName) === "Boolean", resolveRefClazzName(item.typ.refClazzName) === "Long", + resolveRefClazzName(item.typ.refClazzName) === "Integer", ].includes(true); } diff --git a/designer/restmodel/src/main/scala/pl/touk/nussknacker/restmodel/validation/PrettyValidationErrors.scala b/designer/restmodel/src/main/scala/pl/touk/nussknacker/restmodel/validation/PrettyValidationErrors.scala index a2328fda58d..0d89489ce9b 100644 --- a/designer/restmodel/src/main/scala/pl/touk/nussknacker/restmodel/validation/PrettyValidationErrors.scala +++ b/designer/restmodel/src/main/scala/pl/touk/nussknacker/restmodel/validation/PrettyValidationErrors.scala @@ -187,19 +187,20 @@ object PrettyValidationErrors { ) case UnsupportedFixedValuesType(paramName, typ, _) => node( - message = s"Fixed values list can only be be provided for type String or Boolean, found: $typ", + message = s"Fixed values list can only be be provided for type String, Integer, Long or Boolean, found: $typ", description = "Please check component definition", paramName = Some(qualifiedParamFieldName(paramName = paramName, subFieldName = Some(TypFieldName))) ) case UnsupportedDictParameterEditorType(paramName, typ, _) => node( - s"Dictionary parameter editor can only be used for parameters of type String, Long or Boolean, found: $typ", - "Please check component definition", + message = + s"Dictionary parameter editor can only be used for parameters of type String, Integer, Long or Boolean, found: $typ", + description = "Please check component definition", paramName = Some(qualifiedParamFieldName(paramName = paramName, subFieldName = Some(TypFieldName))) ) case EmptyFixedListForRequiredField(paramName, _) => node( - s"Non-empty fixed list of values have to be declared for required parameter", + message = s"Non-empty fixed list of values have to be declared for required parameter", description = "Please add a value to the list of possible values", paramName = Some(qualifiedParamFieldName(paramName = paramName, subFieldName = Some(InputModeFieldName))) ) diff --git a/designer/server/src/test/scala/pl/touk/nussknacker/ui/api/DictApiHttpServiceSpec.scala b/designer/server/src/test/scala/pl/touk/nussknacker/ui/api/DictApiHttpServiceSpec.scala index c695c49d5f0..8a9d36af310 100644 --- a/designer/server/src/test/scala/pl/touk/nussknacker/ui/api/DictApiHttpServiceSpec.scala +++ b/designer/server/src/test/scala/pl/touk/nussknacker/ui/api/DictApiHttpServiceSpec.scala @@ -31,8 +31,14 @@ class DictApiHttpServiceSpec .post(s"$nuDesignerHttpAddress/api/processDefinitionData/${Streaming.stringify}/dicts") .Then() .statusCode(200) - .equalsJsonBody("[]") - + .equalsJsonBody( + s"""[ + | { + | "id" : "integer_dict", + | "label" : "integer_dict" + | } + |]""".stripMargin + ) } "return proper list for expected type String" in { @@ -83,6 +89,10 @@ class DictApiHttpServiceSpec .statusCode(200) .equalsJsonBody( s"""[ + | { + | "id": "integer_dict", + | "label": "integer_dict" + | }, | { | "id" : "long_dict", | "label" : "long_dict" @@ -91,7 +101,7 @@ class DictApiHttpServiceSpec ) } - "return proper list for expected type BigDecimal" in { + "return proper list for expected type BigInteger" in { given() .when() .basicAuthAllPermUser() @@ -107,6 +117,11 @@ class DictApiHttpServiceSpec .statusCode(200) .equalsJsonBody( s"""[ + | + | { + | "id": "integer_dict", + | "label": "integer_dict" + | }, | { | "id" : "long_dict", | "label" : "long_dict" diff --git a/docs/Changelog.md b/docs/Changelog.md index 4c89c150082..cb3371c7b24 100644 --- a/docs/Changelog.md +++ b/docs/Changelog.md @@ -27,6 +27,7 @@ * Improved scenario state management to include information about current and deployed versions and allow more customization * [#7184](https://github.com/TouK/nussknacker/pull/7184) Improve Nu Designer API notifications endpoint, to include events related to currently displayed scenario * [#7323](https://github.com/TouK/nussknacker/pull/7323) Improve Periodic DeploymentManager db queries +* [#7341](https://github.com/TouK/nussknacker/pull/7341) Added possibility to choose presets and define lists for Integer typed parameter inputs in fragments. ### 1.18.2 (Not released) * [#7324](https://github.com/TouK/nussknacker/pull/7324) Fix: Passing Flink Job Global Params diff --git a/engine/flink/management/dev-model/src/main/scala/pl/touk/nussknacker/engine/management/sample/DevProcessConfigCreator.scala b/engine/flink/management/dev-model/src/main/scala/pl/touk/nussknacker/engine/management/sample/DevProcessConfigCreator.scala index 0ce3696e419..d2a21c0919f 100644 --- a/engine/flink/management/dev-model/src/main/scala/pl/touk/nussknacker/engine/management/sample/DevProcessConfigCreator.scala +++ b/engine/flink/management/dev-model/src/main/scala/pl/touk/nussknacker/engine/management/sample/DevProcessConfigCreator.scala @@ -242,6 +242,7 @@ class DevProcessConfigCreator extends ProcessConfigCreator { BusinessConfigDictionary.id -> BusinessConfigDictionary.definition, BooleanDictionary.id -> BooleanDictionary.definition, // not available through global variables, but still available through DictParameterEditor LongDictionary.id -> LongDictionary.definition, // not available through global variables, but still available through DictParameterEditor + IntegerDictionary.id -> IntegerDictionary.definition // not available through global variables, but still available through DictParameterEditor ) ) } diff --git a/engine/flink/management/dev-model/src/main/scala/pl/touk/nussknacker/engine/management/sample/dict/IntegerDictionary.scala b/engine/flink/management/dev-model/src/main/scala/pl/touk/nussknacker/engine/management/sample/dict/IntegerDictionary.scala new file mode 100644 index 00000000000..02a29313783 --- /dev/null +++ b/engine/flink/management/dev-model/src/main/scala/pl/touk/nussknacker/engine/management/sample/dict/IntegerDictionary.scala @@ -0,0 +1,23 @@ +package pl.touk.nussknacker.engine.management.sample.dict + +import pl.touk.nussknacker.engine.api.dict.embedded.EmbeddedDictDefinition +import pl.touk.nussknacker.engine.api.dict.{DictDefinition, DictInstance, ReturningKeyWithoutTransformation} +import pl.touk.nussknacker.engine.api.typed.typing +import pl.touk.nussknacker.engine.api.typed.typing.Typed + +object IntegerDictionary { + val id: String = "integer_dict" + + val definition: DictDefinition = new EmbeddedDictDefinition with ReturningKeyWithoutTransformation { + override def valueType(dictId: String): typing.SingleTypingResult = Typed.typedClass[java.lang.Integer] + + override def labelByKey: Map[String, String] = Map( + "-2147483648" -> "large (negative) number", + "42" -> "small number", + "2147483647" -> "big number" + ) + + } + + val instance: DictInstance = DictInstance(id, definition) +} diff --git a/scenario-compiler/src/main/scala/pl/touk/nussknacker/engine/compile/nodecompilation/FragmentParameterValidator.scala b/scenario-compiler/src/main/scala/pl/touk/nussknacker/engine/compile/nodecompilation/FragmentParameterValidator.scala index f60b879a671..7db72ed37b7 100644 --- a/scenario-compiler/src/main/scala/pl/touk/nussknacker/engine/compile/nodecompilation/FragmentParameterValidator.scala +++ b/scenario-compiler/src/main/scala/pl/touk/nussknacker/engine/compile/nodecompilation/FragmentParameterValidator.scala @@ -38,12 +38,14 @@ import scala.util.Try object FragmentParameterValidator { val permittedTypesForEditors: List[FragmentClazzRef] = List( - FragmentClazzRef[java.lang.Boolean], FragmentClazzRef[String], + FragmentClazzRef[java.lang.Boolean], + FragmentClazzRef[java.lang.Integer], FragmentClazzRef[java.lang.Long], FragmentClazzRef("String"), FragmentClazzRef("Boolean"), - FragmentClazzRef("Long") + FragmentClazzRef("Integer"), + FragmentClazzRef("Long"), ) }