Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review advanced light-flat matching #22

Closed
TomyCesaille opened this issue Jan 10, 2025 · 0 comments · Fixed by #25
Closed

Review advanced light-flat matching #22

TomyCesaille opened this issue Jan 10, 2025 · 0 comments · Fixed by #25

Comments

@TomyCesaille
Copy link
Owner

TomyCesaille commented Jan 10, 2025

Description

Having

  • a night session with flats Flat_150.0ms_Bin1_O_gain0_20240624-081331_-10.0C_0001, ...
  • another night session with Flat_120.0ms_Bin1_O_gain0_20240627-075447_-9.6C_0001, ....

❌ The bulb is not identical but we're clearly in the flat set having multiple sequences. And we wish for manual matching.

👉 The most logical way to resolve this is to only consider the bin+filter for flats (and GAIN once we stop ignoring this aspect in the matching) to detect multiple similar sequences. Ignoring bulb as this is not meaningful for matching nor 'stable' with auto bulb from ASIAIR.

Another way to look at it is to always propose the manual mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant