Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing com.oxygenxml.diagrams.svg plugin for diagrams, website missing diagram #29

Open
SmartLayer opened this issue Jul 20, 2023 · 3 comments
Assignees

Comments

@SmartLayer
Copy link
Contributor

SmartLayer commented Jul 20, 2023

thanks to our dependency on com.oxygenxml.diagrams.svg plugin, which requires manual installation as detailed in the README.md. Due to this manual installation requirement, the GitHub default action for compiling the DITA output is unlikely to correctly process these diagrams.

It's generate
Reproduction Steps

  1. Install plugin com.oxygenxml.diagrams.svg per README.
  2. Generate a pdf on your computer, using src/usecase/guide$ dita -i air.cab.md -f pdf -o /tmp/ it will be in /tmp/
  3. see in that PDF file there is diagram - here I made it for you air.cab.pdf
  4. Verify the diagram is also there on the web output (embedded inside the HTML page) by run the following DITA command on your local machine:
    $ dita --project config/smartlayer-docsite.yaml -o out/document.smartlayer.network
    
  5. See that the diagram is nowhere to be seen in https://document.smartlayer.network/usecase/guide/air.cab.html
@SmartLayer SmartLayer self-assigned this Jul 20, 2023
@SmartLayer SmartLayer assigned JustinFeng and unassigned SmartLayer Jul 20, 2023
@SmartLayer
Copy link
Contributor Author

any update? @JustinFeng

@SmartLayer SmartLayer changed the title started to use com.oxygenxml.diagrams.svg plugin for diagrams, expecting to break CI missing com.oxygenxml.diagrams.svg plugin for diagrams, website missing diagram Aug 17, 2023
@SmartLayer
Copy link
Contributor Author

update? @JustinFeng @abcfy2 @foxgem

abcfy2 added a commit that referenced this issue Aug 23, 2023
@abcfy2
Copy link
Contributor

abcfy2 commented Aug 23, 2023

Hi @weiwu-zhang . This should be fixed. You may enable air.cab.md again. Thanks.

CC @JustinFeng @foxgem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants