New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pty on android #45

Open

bmcpt opened this issue Jun 30, 2022 · 1 comment

bmcpt commented Jun 30, 2022 •

edited

Loading

The client avoids creating a pty shell on android. What is the reason for that?

Owner

TimeToogo commented Jul 1, 2022

Hi @bmcpt,
PTY shells are excluded from iOS and android builds here: https://github.com/TimeToogo/tunshell/blob/master/tunshell-client/src/shell/server/mod.rs#L110
From memory it may have been because the pty crate failed to build against the android target but I could be wrong. Feel free to submit a PR if you are able to enable it for these targets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment