Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

about the early stopping #62

Open
llw0727 opened this issue May 28, 2020 · 1 comment
Open

about the early stopping #62

llw0727 opened this issue May 28, 2020 · 1 comment

Comments

@llw0727
Copy link

llw0727 commented May 28, 2020

hi Tim,sorry to bother you!
i noticed you used early stopping in the paper,but i didnt found the code
could u show the code about the early stopping :)

@TimDettmers
Copy link
Owner

This is something that was not really done well by me. There is no early stopping code. Instead what I do is I go through the logs and look at the best validation mean reciprocal rank and then I noted the test results for that epoch. It would have been better to implement that rather than doing it manually. It would be better to add it in retrospect since this can be quite confusing. I might have some time to do this next week.

My colleague was working with his own codebase to produce results for DistMult and ComplEx and he might have used early stopping. His codebase is this one: https://github.com/uclnlp/inferbeddings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants