Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Make it more obvious that $:/DefaultTiddlers setting can handle filter-expressions #8729

Open
wants to merge 1 commit into
base: tiddlywiki-com
Choose a base branch
from

Conversation

pmario
Copy link
Member

@pmario pmario commented Nov 4, 2024

Make it more obvious that $:/DefaultTiddlers setting can handle filter-expressions

Edit: Fixing some typos
Edit 24.11.16: Adjusted one more time
Edit 24.11.17: Test push for build-bot

Copy link

github-actions bot commented Nov 4, 2024

Confirmed: pmario has already signed the Contributor License Agreement (see contributing.md)

Copy link
Member

@Jermolene Jermolene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @pmario sorry for so many comments on a small PR but it touches on some tricky issues about how we teach the fundamentals of TW.

There are two ways default tiddlers can be defined:

* A [[title-list|Title List]] eg: `TiddlerTitles` and `[[Titles with spaces]]`
* Filter expressions, using [[filter operators|Filter Operators]] eg: `[tag[HelloThere]]`

At startup, the text of the system tiddler [[$:/DefaultTiddlers]] is retrieved and evaluated as a [[filter expression|Filter Expression]]. The resulting list of titles is then inserted into the [[story river|Story River]].
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel that we already explain here that a filter expression can be used to specify the default tiddlers. Perhaps we should consider rewriting this paragraph to further emphasize that, rather than add the paragraph above?

Copy link
Member Author

@pmario pmario Nov 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we should consider rewriting this paragraph to further emphasize that, rather than add the paragraph above?

The paragraph has been there for years and extracting the information that DefaultTiddlers can handle filter expressions is not obvious and hard to find, as can be seen at the discussion at Talk

A bullet-list attracts attention to the points that are important. I did not want to remove the paragraph, because I think its OK to explain functions in different ways for different users.

But English is not my main language. So I would be happy for an example.

@pmario pmario force-pushed the docs-make-it-more-obvious-that-defaulttiddlers-setting-can-handle-filter-expressions-20241104160223730 branch from 0466011 to 7aacf9b Compare November 4, 2024 20:49
@pmario pmario force-pushed the docs-make-it-more-obvious-that-defaulttiddlers-setting-can-handle-filter-expressions-20241104160223730 branch from f586c4a to a978a6e Compare November 16, 2024 21:02
@pmario
Copy link
Member Author

pmario commented Nov 16, 2024

@Jermolene -- Is it possible, that Netlify also creates previews for the tiddlywiki-com branch? That would be nice.

@Jermolene
Copy link
Member

Hi @pmario I think I've fixed it, if you could kindly push an update to this PR to check.

@pmario pmario force-pushed the docs-make-it-more-obvious-that-defaulttiddlers-setting-can-handle-filter-expressions-20241104160223730 branch from a978a6e to 5fa5d88 Compare November 17, 2024 13:19
Copy link

netlify bot commented Nov 17, 2024

Deploy Preview for tiddlywiki-previews ready!

Name Link
🔨 Latest commit 5fa5d88
🔍 Latest deploy log https://app.netlify.com/sites/tiddlywiki-previews/deploys/6739ed6ace011c0008099692
😎 Deploy Preview https://deploy-preview-8729--tiddlywiki-previews.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 17, 2024

Deploy Preview for tiddlywiki-previews ready!

Name Link
🔨 Latest commit 5fa5d88
🔍 Latest deploy log https://app.netlify.com/sites/tiddlywiki-previews/deploys/6739ed6b825fa90008e95caa
😎 Deploy Preview https://deploy-preview-8729--tiddlywiki-previews.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pmario
Copy link
Member Author

pmario commented Nov 17, 2024

@Jermolene -- The preview has been built: https://deploy-preview-8729--tiddlywiki-previews.netlify.app/#DefaultTiddlers

But there are 2 messages added to the PR thread. I am not sure if that is intended. See: #8729

When I do create a new DOCS PR we will see.

@Jermolene
Copy link
Member

@Jermolene -- The preview has been built: https://deploy-preview-8729--tiddlywiki-previews.netlify.app/#DefaultTiddlers

But there are 2 messages added to the PR thread. I am not sure if that is intended. See: #8729

When I do create a new DOCS PR we will see.

Hi @pmario it looks like it is building these PRs twice, I'll have to investigate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants