Minor fixes and dependabot bumps #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codecov action version bump
|
do we want caching for test(latest and lts)s package building? we should either disable the info or enable caching... and for lts testing: do we want to use 1.6 specifically or should we change to "lts" label instead of "1.6" everywhere? |
|
action outputs checked: no wanings, no notes Ready to merge |
ThummeTo
reviewed
Dec 23, 2024
| @@ -930,7 +930,7 @@ end | |||
| export fmi2GetFMUstate | |||
|
|
|||
| """ | |||
| fmi2FreeFMUstate!(c::FMU2Component, state::fmi2FMUstate) | |||
| fmi2FreeFMUstate(c::FMU2Component, state::fmi2FMUstate) | |||
There was a problem hiding this comment.
This is a breaking change, did you upstream test this (so check of FMI/FMIFlux still work?).
Why do you want to change this?
There was a problem hiding this comment.
I would say, this is not a breaking change, it is a docstring (although it meight break the FMI-Doc action, but that will be easier to fix afterwards)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.