Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change type parsing to be a bit cleaner #39

Open
alexdovzhanyn opened this issue Oct 1, 2024 · 2 comments
Open

Change type parsing to be a bit cleaner #39

alexdovzhanyn opened this issue Oct 1, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest A good issue to work on for Hacktoberfest help wanted Extra attention is needed

Comments

@alexdovzhanyn
Copy link
Collaborator

Currently types get parsed when they are written like so:

x<Function<Number, Number, Number>> = () -> ...

this works fine, but I think we should change the type declaration syntax to be a bit easier to read. It would be preferable to write type declarations like so:

x: Function<Number, Number, Number> = () -> ...

This is a little clearer as to what is the variable and what is the type.

  • [] Update the parser to correctly parse type declarations in the new format
  • [] Update all of the lexer, parser, typechecker, and codegen tests to use the new type declaration format. The logic of the tests themselves should not need to be updated.
@alexdovzhanyn alexdovzhanyn added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers hacktoberfest A good issue to work on for Hacktoberfest labels Oct 1, 2024
@ohmschrodinger
Copy link

can you assign this work to me?

@alexdovzhanyn
Copy link
Collaborator Author

@ohmschrodinger you got it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest A good issue to work on for Hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants