Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to v10.10.0 #87

Closed
2 of 4 tasks
Thefrank opened this issue Oct 26, 2024 · 6 comments
Closed
2 of 4 tasks

Update to v10.10.0 #87

Thefrank opened this issue Oct 26, 2024 · 6 comments

Comments

@Thefrank
Copy link
Owner

Build:

  • Build Jellyfin-Server for FreeBSD.13-x64
  • Build Jellyfin-Server for FreeBSD.14-x64
  • Build Jellyfin-Web for FreeBSD.13-x64
  • Error: Embedded Dart Sass couldn't find the embedded compiler executable. Please make sure the optional dependency sass-embedded-freebsd-x64 is installed in node_modules.
  • F
  • Build Jellyfin-Web for FreeBSD.14-x64
  • See above

Train of thought notes might delete later:


Changes in the sass dependencies seem to have caused this. I guess there is no longer a Dart2JS fallback? node-sass is EOL sass/node-sass#3424 "Projects that still use it should move onto Dart Sass." OSes that are not supported by Dart get left out?
Dart is a Google project. RIP

Some light reading:
In the past 11 years the dart-lang team has not been given the resources to support FreeBSD.
dart-lang/sdk#10260 and dart-lang/sdk#52374

Others:
nanoc/nanoc#1710
sass-contrib/sass-embedded-host-ruby#227
sass/dart-sass#1173
jekyll/jekyll#9462
owen2345/camaleon-cms#1098

Progress?:

sass/dart-sass#2325 with sass/dart-sass#2413 and sass/embedded-host-node#344

@nex3
Copy link

nex3 commented Oct 28, 2024

I guess there is no longer a Dart2JS fallback?

There definitely is a pure JS distribution of Dart Sass which should work totally fine on FreeBSD. It's available as the sass package on npm.

@Thefrank
Copy link
Owner Author

Thanks for the heads up! I will see what I can do about working around the requirement for an embedded compiler when I get some time later in the week

@bapt
Copy link

bapt commented Nov 6, 2024

my search engine juste made me encounter this issue, for your information I have updated the FreeBSD port to 10.10.1 and added a port for libskiasharp (built in the ports tree) to workaround sass-embeded issue, I just removed from the package*.json all reference to sass-embeded and it fallsback on using sass

@Thefrank
Copy link
Owner Author

Thefrank commented Nov 7, 2024

@bapt Thank you! Sorry about not replying sooner.

Everyone else:
This is now in ports for people missing it here. It should be on lastest soonish https://www.freshports.org/multimedia/jellyfin/
Those on quarterly will not get this until the next quarterly. There were no security fixes.

This repo is now redundant, in a good way, but I will be shutting it down in the next few days.

@Thefrank Thefrank closed this as completed Nov 7, 2024
@bapt
Copy link

bapt commented Nov 8, 2024

@bapt Thank you! Sorry about not replying sooner.

Everyone else:
This is now in ports for people missing it here. It should be on lastest soonish https://www.freshports.org/multimedia/jellyfin/
Those on quarterly will not get this until the next quarterly. There were no security fixes.

This repo is now redundant, in a good way, but I will be shutting it down in the next few days.

given you have been the first to work on this if you want maintainership or want to help working on the ports you are more welcome! thanks a lot for all your work!!!!

@Thefrank
Copy link
Owner Author

Thefrank commented Nov 9, 2024

@bapt
TL;DR: You/others maintaining the port is fine. I will stick a big "Use pkg/ports to install jellyfin" at the top to reduce confusion.

Full:
Oh! I am not worried about others maintaining the port. My concern was more over any confusion by users on where to find the binaries and where to get support. Locking/removing this repo should(?) help resolve that if you want to go that direction.

"jellyfin freebsd", on google, shows my repo second, under Jellyfin's official site; the order is reversed on bing. Freshports is at the bottom of the first page for google and does not make the first page for bing.

I had kept this repo open as an alternative for users that wanted a jellyfin binary sooner than what was provided in ports.
I also made a few scripts to run in azure pipelines that would run tests and update the Makefile and others in the ports folder for those that wanted to use poudriere to build a package. Nice to have, but not really "port maintainer" rigorous (e.g., it broke when moving to sass-embeded, libSkiaSharp was a binary as I did not have time to make a correct port for it). I feel I do not have the time to maintain a port, but I do leave my process where I can (comments were removed later to keep the file clean e0d1197)

I also don't mind continuing jellyfin support here. People gravitate here for support anyways even after a port arrived on FreeBSD.
I will fix the readme to reflect the correct location (pkg install or ports) for acquiring the package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants