Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message when navigating to /Explore page #1821

Open
jamieu opened this issue Sep 4, 2024 · 1 comment
Open

Error message when navigating to /Explore page #1821

jamieu opened this issue Sep 4, 2024 · 1 comment

Comments

@jamieu
Copy link
Member

jamieu commented Sep 4, 2024

Page flashes to error message, before moving onto 'Explore' page when navigating from /search/group

Also make 'visit our Explore page to see all topic and themes' underlined in CSS

Screenshot 2024-09-04 at 14 51 09
@evancp87
Copy link
Contributor

evancp87 commented Dec 3, 2024

@jamieu I think the issue is down to the state management setup of the search component, and clashes between client-side routing with Page.JS vs server side routing.

A similar issue is found when navigating back from the search page to the homepage, resulting in a not found page. This is due to use of sessionStorage, which adds entries to the navigation history by saving the previous path, but only starts from /search, and doesn't include the homepage route.

With the explore page, there is likely a race condition between Page.js trying to render new content on the client side, and the browser trying to navigate to the new page (/explore). Page.js attempts to load /search/explore, before the browser navigates to the correct page, as sessionStorage still contains the old path (/search), resulting in a not found page as there is not a /search/explore page.

To fix this, there will need to be a change in the state management to align with the browser's navigation state, or a way for the explore page to be better integrated into the flow, as apart from the records that the user navigates to, I don't think there's anywhere else that the user is taken away from search page.

@evancp87 evancp87 removed their assignment Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants