Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

underline current section in nav menu #1796

Open
tobystokes opened this issue Jul 25, 2024 · 0 comments
Open

underline current section in nav menu #1796

tobystokes opened this issue Jul 25, 2024 · 0 comments

Comments

@tobystokes
Copy link
Member

Could we underline Explore in Search | Explore | About nav when in relevant sections.

image

The site navigation (search/explore/about) can already do this, if marked with aria-current="true"
the template is already evaluating something to do it, but i don't think that's the right thing...?

I could do it in the front end by getting the first segment from location.pathname but it would be better and i expect as easy to do it server-side.

Although that first url segment is a good method, as all search results pages begin /search while the the objects themselves don't

@evancp87 evancp87 self-assigned this Aug 29, 2024
@evancp87 evancp87 removed their assignment Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants