Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate search queries into dynamic title pages #1738

Open
evancp87 opened this issue May 2, 2024 · 0 comments
Open

Integrate search queries into dynamic title pages #1738

evancp87 opened this issue May 2, 2024 · 0 comments

Comments

@evancp87
Copy link
Contributor

evancp87 commented May 2, 2024

This ticket was intended to expand on this closed ticket, which both fixed the dynamic page titles and expanded further. The idea was to intregrate search queries into dynamic title pages, alongside the filters.

Most of the work was done and mostly working, but I encountered issues with the search query overwriting the title derived from the filters, or the filters overwriting the title from the search query, instead of combining together, e.g. "Search results for painting in Art + Collection | Science Museum Collection".

I think this is due to server state and the routing/rerendering of the search results page, and how data (and which data) persists. This requires more thinking on that side of things, so the titles work as expected.

Update 12 November: To clarify the last paragraph, the filters are persisted in server state, whereas the search queries are (i think) part of Page.js and the SPA style routing, so currently cannot exist together. This can probably be circumvented, but will require time and research

@evancp87 evancp87 self-assigned this May 2, 2024
@evancp87 evancp87 removed their assignment Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant