You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This ticket was intended to expand on this closed ticket, which both fixed the dynamic page titles and expanded further. The idea was to intregrate search queries into dynamic title pages, alongside the filters.
Most of the work was done and mostly working, but I encountered issues with the search query overwriting the title derived from the filters, or the filters overwriting the title from the search query, instead of combining together, e.g. "Search results for painting in Art + Collection | Science Museum Collection".
I think this is due to server state and the routing/rerendering of the search results page, and how data (and which data) persists. This requires more thinking on that side of things, so the titles work as expected.
Update 12 November: To clarify the last paragraph, the filters are persisted in server state, whereas the search queries are (i think) part of Page.js and the SPA style routing, so currently cannot exist together. This can probably be circumvented, but will require time and research
The text was updated successfully, but these errors were encountered:
This ticket was intended to expand on this closed ticket, which both fixed the dynamic page titles and expanded further. The idea was to intregrate search queries into dynamic title pages, alongside the filters.
Most of the work was done and mostly working, but I encountered issues with the search query overwriting the title derived from the filters, or the filters overwriting the title from the search query, instead of combining together, e.g. "Search results for painting in Art + Collection | Science Museum Collection".
I think this is due to server state and the routing/rerendering of the search results page, and how data (and which data) persists. This requires more thinking on that side of things, so the titles work as expected.
Update 12 November: To clarify the last paragraph, the filters are persisted in server state, whereas the search queries are (i think) part of Page.js and the SPA style routing, so currently cannot exist together. This can probably be circumvented, but will require time and research
The text was updated successfully, but these errors were encountered: