Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RoomStateManager.race will always return false. #221

Open
1 task done
ThePhar opened this issue Nov 21, 2024 · 0 comments
Open
1 task done

RoomStateManager.race will always return false. #221

ThePhar opened this issue Nov 21, 2024 · 0 comments
Labels
is: bug Something isn't working

Comments

@ThePhar
Copy link
Owner

ThePhar commented Nov 21, 2024

I have read the above disclaimer and I am submitting a new bug report and have verified no other duplicate reports exist in the Issues or Discussions tabs.

  • Confirm

Describe the Issue

As described in the title, this field is never updated on connection.

Likely this is to remain as is until 2.1's "manager ready system" is implemented, so that an event does not need to be created as the client would need to fetch the race mode from data storage, which allows a time gap where a client has connected, but race mode is still being fetched, meaning the property is incorrect. The ready system would prevent this.

It is marked as experimental at least, so a jsdoc should probably be created for 2.0.x, to inform that this will always return false until 2.1 and if needed, should be fetched manually via DataStorageManager.

Reproduction Steps

n/a

Expected Behavior

Expected to match server's race mode after connection.

Library Version

2.0.4

Environment / Runtime

Any environments

Project Repository

No response

Additional Notes, Screenshots, or Files

No response

@ThePhar ThePhar added the is: bug Something isn't working label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant