From 06204db05c04a623e6a36f6629bbc8b68b8ef0c2 Mon Sep 17 00:00:00 2001 From: Jonathan Green Date: Mon, 16 Sep 2024 17:00:30 -0300 Subject: [PATCH 1/2] Remove unused Overdrive credentials from the database --- ...3d6_remove_unused_overdrive_credentials.py | 27 +++++++++++++++++++ 1 file changed, 27 insertions(+) create mode 100644 alembic/versions/20240916_87901a6323d6_remove_unused_overdrive_credentials.py diff --git a/alembic/versions/20240916_87901a6323d6_remove_unused_overdrive_credentials.py b/alembic/versions/20240916_87901a6323d6_remove_unused_overdrive_credentials.py new file mode 100644 index 000000000..6d60fc973 --- /dev/null +++ b/alembic/versions/20240916_87901a6323d6_remove_unused_overdrive_credentials.py @@ -0,0 +1,27 @@ +"""Remove unused Overdrive credentials + +Revision ID: 87901a6323d6 +Revises: 350a29bf0ff0 +Create Date: 2024-09-16 19:54:56.986491+00:00 + +""" +from alembic import op + +# revision identifiers, used by Alembic. +revision = "87901a6323d6" +down_revision = "350a29bf0ff0" +branch_labels = None +depends_on = None + + +def upgrade() -> None: + # Clean out the old unused credential objects, so they are not hanging around and causing confusion + # in the future. + op.execute( + "DELETE from credentials WHERE type is NULL and patron_id is NULL and data_source_id in " + "(SELECT id from datasources where name = 'Overdrive')" + ) + + +def downgrade() -> None: + pass From e0e000e54d6eed143f6d4939f73596bca7c2f092 Mon Sep 17 00:00:00 2001 From: Jonathan Green Date: Wed, 2 Oct 2024 13:05:19 -0300 Subject: [PATCH 2/2] Pre-commit fixes --- .../20240916_87901a6323d6_remove_unused_overdrive_credentials.py | 1 + 1 file changed, 1 insertion(+) diff --git a/alembic/versions/20240916_87901a6323d6_remove_unused_overdrive_credentials.py b/alembic/versions/20240916_87901a6323d6_remove_unused_overdrive_credentials.py index 6d60fc973..8486c9b06 100644 --- a/alembic/versions/20240916_87901a6323d6_remove_unused_overdrive_credentials.py +++ b/alembic/versions/20240916_87901a6323d6_remove_unused_overdrive_credentials.py @@ -5,6 +5,7 @@ Create Date: 2024-09-16 19:54:56.986491+00:00 """ + from alembic import op # revision identifiers, used by Alembic.