-
Notifications
You must be signed in to change notification settings - Fork 568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gpl routability log change #6269
Merged
eder-matheus
merged 11 commits into
The-OpenROAD-Project:master
from
gudeh:gpl-routability-log-change
Nov 29, 2024
Merged
gpl routability log change #6269
eder-matheus
merged 11 commits into
The-OpenROAD-Project:master
from
gudeh:gpl-routability-log-change
Nov 29, 2024
+8
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Augusto Berndt <[email protected]>
Signed-off-by: Augusto Berndt <[email protected]>
Signed-off-by: Augusto Berndt <[email protected]>
Signed-off-by: Augusto Berndt <[email protected]>
Signed-off-by: Augusto Berndt <[email protected]>
This PR should cover the request in issue #5201 |
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: Augusto Berndt <[email protected]>
clang-tidy review says "All clean, LGTM! 👍" |
eder-matheus
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor modification on routability log message from "numCall" variable name to "iteration", which is exactly what the internal variable represents.
Noticed that the inflation and bloat counters are unused in practice. The counters exceed their maximum values without triggering any functionality.
Bloat is expected to occur when inflation reaches its maximum iterations, but no action is associated with this condition. This appears to be a remnant of an earlier idea that was not fully implemented or was removed, leaving behind unused code.