Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gpl routability log change #6269

Merged

Conversation

gudeh
Copy link
Contributor

@gudeh gudeh commented Nov 29, 2024

Minor modification on routability log message from "numCall" variable name to "iteration", which is exactly what the internal variable represents.

Noticed that the inflation and bloat counters are unused in practice. The counters exceed their maximum values without triggering any functionality.

Bloat is expected to occur when inflation reaches its maximum iterations, but no action is associated with this condition. This appears to be a remnant of an earlier idea that was not fully implemented or was removed, leaving behind unused code.

@gudeh
Copy link
Contributor Author

gudeh commented Nov 29, 2024

This PR should cover the request in issue #5201

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Signed-off-by: Augusto Berndt <[email protected]>
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@eder-matheus eder-matheus merged commit c90cd95 into The-OpenROAD-Project:master Nov 29, 2024
11 checks passed
@gudeh gudeh deleted the gpl-routability-log-change branch November 30, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants