odb: protecting dbModule::makeUniqueDbModule()::name_id_map with a lock #6245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lucas Yuki Imamura <[email protected]>
|
clang-tidy review says "All clean, LGTM! 👍" |
maliberty
reviewed
Nov 26, 2024
src/odb/src/db/dbModule.cpp
Outdated
| @@ -559,11 +560,15 @@ dbModule* dbModule::makeUniqueDbModule(const char* cell_name, | |||
| std::string module_name = orig_cell_name + '_' + std::string(inst_name); | |||
| do { | |||
| std::string full_name = module_name; | |||
|
|
|||
| name_id_map_mutex.lock(); | |||
There was a problem hiding this comment.
Its better to use std::unique_lock than manual lock and unlock calls (eg exception safety).
Signed-off-by: Lucas Yuki Imamura <[email protected]>
|
clang-tidy review says "All clean, LGTM! 👍" |
|
This does not seem like an acceptable solution. If you have multiple odb's won't calls to makeUniqueDbModule interfere with each other? |
|
Interfere in the sense that the numbering will depend on the order of the calls. It won't be a thread safety issue but it could cause some non-determinism in the names. |
|
I think the easiest thing to do is move name_id_map to be a non-persistent member of dbBlock. No lock is then needed and the extra memory will disappear on close. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Protects the static variable name_id_map from the dbModule::makeUniqueDbModule method with a lock (issue #5981)