Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5th comparison round #26

Open
ThaDafinser opened this issue May 10, 2016 · 10 comments
Open

5th comparison round #26

ThaDafinser opened this issue May 10, 2016 · 10 comments

Comments

@ThaDafinser
Copy link
Owner

ThaDafinser commented May 10, 2016

Whoop whoop!

The 5th comparison round is out. Now with over 33.000 user agents!
http://thadafinser.github.io/UserAgentParserComparison/

New providers

  • splitted Browscap into their 3 data files (previous only full)
  • JenssegersAgent (based on MobileDetectLib)
  • UserAgentApiCom
  • Zsxsoft

Changes

  • better UA detail page, with results from multiple testsuites (if available)
  • more UA from more testsuites

// cc
Browscap @asgrim @mimmi20
DonatjUAParser @donatj
JenssegersAgent @jenssegers
NeutrinoApiCom @NeutrinoAPI
PiwikDeviceDetector @sgiehl
SinergiBrowserDetector @gabrielbull
UAParser @lstrojny
UserAgentApiCom _TODO_
UserAgentStringCom _TODO_
WhatIsMyBrowserCom @whatismybrowser
WhichBrowser @NielsLeenheer
Woothee @tagomoris
Wurfl @mimmi20
Zsxsoft @zsxsoft

@mimmi20
Copy link

mimmi20 commented May 10, 2016

@ThaDafinser The calculation of how often an useragent was found is wrong.
see this Sample-Ua: http://thadafinser.github.io/UserAgentParserComparison/v5/user-agent-detail/0d/3a/0d3a2478-c203-4e13-9d0f-79cf22b5c60a.html

In the overviewpage (http://thadafinser.github.io/UserAgentParserComparison/v5/not-detected/BrowscapFull/no-result-found.html) is stated that this UA was found two times, but in the detail page it is only found one time.

Are you counting the Test suites also? Then the Test suite may be counted two times.

For this sample UA, even the UA is from Browscap, you should not count this a found result, because we return our default result there.

@ThaDafinser
Copy link
Owner Author

@mimmi20 need to remove such test results further.

I will change the count() result to be only from real results and not from test suite results.

@ThaDafinser
Copy link
Owner Author

Corrected @mimmi20

image

The actual counted result is from DonatjUAParser

@zsxsoft
Copy link

zsxsoft commented May 13, 2016

I found my parser made many mistakes in device band. XD

@ThaDafinser
Copy link
Owner Author

@zsxsoft that's one target of the comparison, to find possible wrong detections.

Hope you can use it to improve your package

@ThaDafinser
Copy link
Owner Author

I slightly changed the comparison at the 17 March.

I added the additional headers from the testsuite of WhichBrowser.
So the expected results are correct.

Example:
http://thadafinser.github.io/UserAgentParserComparison/v5/user-agent-detail/61/31/613125d1-b453-418c-aaf0-98dc6d9cc48d.html

https://github.com/ThaDafinser/UserAgentParserComparison/commits/gh-pages

@ThaDafinser
Copy link
Owner Author

After being "silent" - the next comparison round will come soon.

The target date is set to the 1st/2nd October 2016.

After that date the comparison will be run half yearly, starting with January.

@mimmi20
Copy link

mimmi20 commented May 11, 2017

Do you have any news here?

@ThaDafinser
Copy link
Owner Author

Not yet. But it's really time for it....will add your provider first and then we can work on this next.

@lonnylot
Copy link

These stats are awesome, but dated. Would be great to see an update of these stats. Let me know if I could help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants