Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Websocket state does not clean up properly #3120

Open
shengquan-ni opened this issue Nov 25, 2024 · 0 comments
Open

Websocket state does not clean up properly #3120

shengquan-ni opened this issue Nov 25, 2024 · 0 comments
Labels

Comments

@shengquan-ni
Copy link
Collaborator

shengquan-ni commented Nov 25, 2024

The web socket state on the front end does not clear properly when the user returns to the dashboard. When entering another workflow, the web socket is re-opened in its previous state.

In #3093, I fixed the issue of websocket re-opeining within the canvas by preventing using the same wid to open websocket again. I believe in the current case we are updating wid in the wid -> null -> wid pattern so my fix does not cover this case.

I think a proper fix for this issue is to clean up every state related to websocket when the user returns to the dashboard.

2024-11-24.4.07.46.mov
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants