Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing XAML Framework ID. #449

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Conversation

khanh245
Copy link

Fix for missing XAML framework Id in some Windows 10 Modal windows.

@ivan-danilov
Copy link
Contributor

Strange error from build server... looks more like an issue on appveyor side.

@khanh245
Copy link
Author

khanh245 commented Jun 29, 2016

I know why...that was my bad.

Btw, what is the image of your worker? Is it using VS 2015 by any chance? Thanks

@ivan-danilov
Copy link
Contributor

I haven't set it up, but judging by the presence of Microsoft Visual Studio 14.0 in the build logs - I guess it is VS2015 indeed.

@dpisanu
Copy link
Contributor

dpisanu commented Jun 30, 2016

A lot of autoformatting changes for a simple addition to the enum "WindowsFramework".
Personally I am not a big fan of calling this. but this is a preference issue.

But as long as there is no defined coding style I would not go about changing on how it is.
Especially the Copyright portions and the displacement of the usings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants