Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relative path passed to ProjectLocation.FromPath can cause silent IIS express failures #227

Open
jacku-abide opened this issue Dec 1, 2015 · 1 comment

Comments

@jacku-abide
Copy link
Contributor

After many hours debugging a problem where I was getting a 404 for my IIS express site when using the following code to setup the project location:

ProjectLocation.FromPath("MyProject.GUI")

I have come to the conclusion that relative paths should not be allowed to be passed to this method, or at the very least they need to be converted to absolute paths before being passed to IIS Express command line (and then on to iisexpress.exe via the generated applicationhost.config).

The reason being that IIS appears not to support relative paths for the virtualDirectory physicalPath setting, which is ultimately where the "MyProject.GUI" string is getting passed to. It returns a 404 in some instances, or may not work at all. But it gives no obvious errors when spun up.

@robdmoore
Copy link
Member

This is great - thanks for the call out!

Do you have any time to create a PR to protect the code in Seleno from this problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants