Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registers a new TrackedDataHandler #87

Open
TropheusJ opened this issue Jan 16, 2024 · 4 comments
Open

Registers a new TrackedDataHandler #87

TropheusJ opened this issue Jan 16, 2024 · 4 comments

Comments

@TropheusJ
Copy link

A new TrackedDataHandler is registered and used to track boat types here.

This is extremely unsafe and makes the mod prone to load-order dependent issues that are impossible to debug.

Instead, a plain field and manual syncing with a custom packet should be used.

@gniftygnome
Copy link
Contributor

Out of curiosity, what load order issue have you discovered?

@haykam821
Copy link
Contributor

There's a more technical explanation at FabricMC/fabric#3482.

@gniftygnome
Copy link
Contributor

Ohh, all yours then. :)

@haykam821
Copy link
Contributor

I believe Brandcraf06/Blockus#322 is also caused by this issue as that mod uses this library.

If necessary, I think we will be able to use the vanilla optional integer tracked data handler instead of a custom one. The only drawback would be needing to convert (and validate) data within the entity which is a slightly less neat split between logic and networking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants