Fix mods screen initialization being slow with many mods #790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prospector
pushed a commit
that referenced
this pull request
Oct 14, 2024
- Fix Mods screen being slow to open the first time - Config screen errors no longer show until after a user has tried to open them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #727.
Changes the check for whether a mod has a config screen to check whether a config screen factory is available, and defers actually constructing individual config screens until the user actually clicks the configure button.
As a side-effect broken config screens are no longer reported on until the user has tried opening the config screen at least once, but I think this should be an acceptable change considering the improved user experience otherwise.