Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection.getEntityRef should throw ConnectionClosedException #206

Open
jd0-sag opened this issue Feb 21, 2017 · 2 comments
Open

Connection.getEntityRef should throw ConnectionClosedException #206

jd0-sag opened this issue Feb 21, 2017 · 2 comments
Assignees

Comments

@jd0-sag
Copy link
Contributor

jd0-sag commented Feb 21, 2017

During the recent change to formalize the exception path through existing end-points and in-flight messages, we didn't also look at the paths to create new end-points.

Ideally, this would be documented to throw this new exception, as well.

@mathieucarbou
Copy link
Member

mathieucarbou commented Apr 20, 2017

@ChrisGreenaway @myronkscott : I am linking this with #215 also because we also ran into this issue. We are always using timed out invokations for voltron and when voltron closes the connection, we have no way to know and if we do a connection.getEntityRef(), it will block indefinitely.

So if we had #215 in place, we could know that the connection is closed and that we cannot use it.

@myronkscott
Copy link
Member

I believe this to be occurring already. Confirm then close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants