Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🐛]: Create Crafts & Additions rolling mill makes rods out of rods and doesn't accept ingots. #636

Open
Jipaso opened this issue Dec 19, 2024 · 2 comments
Labels
1. Type: Bug Inconsistencies or issues which will cause a problem for users. 2. Status: Unverified Bug unverified.

Comments

@Jipaso
Copy link

Jipaso commented Dec 19, 2024

Version modpack Used

0.8.1

Environment

Singleplayer

New Worlds

Yes

Expected Behavior

Expected to produce 2 metal rods by consuming 1 metal ingot.

Actual Behavior

The mill turns 1 rod into 1 rod of the same type.
Screenshot 2024-12-19 163225

Steps to Reproduce

I tried using the rolling mill and the recipes work as shown in EMI.

Additional Information

No response

@Jipaso Jipaso added 1. Type: Bug Inconsistencies or issues which will cause a problem for users. 2. Status: Unverified Bug unverified. labels Dec 19, 2024
@Xikaro Xikaro changed the title Create Crafts & Additions rolling mill makes rods out of rods and doesn't accept ingots. [🐛]: Create Crafts & Additions rolling mill makes rods out of rods and doesn't accept ingots. Dec 21, 2024
@AlertingAvian
Copy link

AlertingAvian commented Dec 26, 2024

Rod input can be fixed by modifying recipes.js ingotItem should have tagPrefix.ingot instead of just tagPrefix (line 151 kubejs/server_scripts/gregtech/recipies.js). EDIT: 3a62265 looks to have already fixed this

Output quantity can be fixed by changing the number on line 148 to 2 const rodItem = ChemicalHelper.get(tagPrefix, material, 2)

const processRod = (tagPrefix, material) => {
	const rodItem = ChemicalHelper.get(tagPrefix, material, 2)
	if (rodItem.isEmpty()) return
	
	const ingotItem = ChemicalHelper.get(tagPrefix.ingot, material, 1) // this line needs to have tagPrefix.ingot not just tagPrefix (and also looks to have already been fixed by 3a62265)
	if (ingotItem.isEmpty()) return

	if (!material.hasFlag(MaterialFlags.GENERATE_ROD) || material == GTMaterials.Wood) return
	if (ingotItem.isEmpty() || rodItem.isEmpty()) return
	
	// Прокатка стержней
	e.custom({
		type: "createaddition:rolling",
		input: ingotItem.toJson(),
		result: rodItem.toJson()
	}).id(`tfg:rolling/${material.getName()}_rod`)
}

@Pyritie
Copy link
Contributor

Pyritie commented Dec 26, 2024

you can submit a pull request, you can edit files through the github website, that's how I've been doing it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. Type: Bug Inconsistencies or issues which will cause a problem for users. 2. Status: Unverified Bug unverified.
Projects
None yet
Development

No branches or pull requests

3 participants