Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues in the configuration #680

Open
ecstrema opened this issue Oct 3, 2024 · 0 comments
Open

Issues in the configuration #680

ecstrema opened this issue Oct 3, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@ecstrema
Copy link

ecstrema commented Oct 3, 2024

Here an aglomerate of issues related to the settings UI and implementation.

  1. You currently have an array of tools, but only one is selected in the General page. All others should not be shown, and only the configuration for this tool should show up, in the same page, just below the tool selection under a section like "Tool options".

image
image

  1. The last point also applies to the linter and formatter settings.
  2. A lot of these options seem completely unrelated:
    • GTKWave installation directory should probably be in a GTWWave tool page
    • The waveform viewer selection should come before all gtkwave options
    • The manual compilation order setting is among those, but has nothing to do. Plus, it seems like something that's more related to a specific tool, although I don't know what it does, and couldn't find documentation for it.
    • And that's just for 1 page with 6 fields.
  3. All sections wich have a single subsection should be a single page. You should not have to first expand the section, then click on "General"

This one is actually pretty funny:
image

Actually, all of this is mostly trivial things, but since the documentation is very very sparse, and examples even rarer, it makes up for something that's super hard to work with, although once you get the hang of it, it works incredibly well!

My recommandation may be very radical, but that is how other extensions work, and I think it works very well.

  1. Move all settings related to the user (not to the project) to vscode's own settings mechanism.
    1. All binary paths (python, make, gtkwave, etc)
    2. All preferences (stutter mode, schematic viewer, etc)
  2. Move all tool settings to configuration files. This is often how these tools are configured anyway.
  3. Is there anything remaining?

Overall, thank you for TerosHDL, it works super well, and integrates nicely with VSCode.

Have a good day!

@ecstrema ecstrema added the enhancement New feature or request label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant