Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if second run of rule does not fire in RuleTester #499

Open
losipiuk opened this issue Feb 3, 2017 · 0 comments
Open

Check if second run of rule does not fire in RuleTester #499

losipiuk opened this issue Feb 3, 2017 · 0 comments

Comments

@losipiuk
Copy link

losipiuk commented Feb 3, 2017

It seems natural that optimizer Rule if run on output of the same Rule should not fire again.
While we may think of rules that do only part of work on first run, and some continuation of work on the second run, it does not seem like necessary feature.

If we agree that we do not need that, let's add a check to RuleTest verifying that:

rule.apply(rule.apply(plan)) == Optional.empty()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant