Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing changes in changelog #5334

Closed
bramkragten opened this issue Jul 15, 2020 · 6 comments
Closed

Missing changes in changelog #5334

bramkragten opened this issue Jul 15, 2020 · 6 comments
Labels
High Priority Issue is a high priority. Home Assistant Icons related to home automation and more specifically, for use in Home Assistant. Question Question from a user.

Comments

@bramkragten
Copy link

For Home Assistant 0.113 we made a conversion to deal with all the breaking changes in 4.9.95 -> 5.3.45.

I found at least one icon that was missing in the changelog, visual-studio-code -> microsoft-visual-studio-code, and I am now worried more might be missing.

Could you verify this in some way?

Thanks!

@bramkragten bramkragten added the Question Question from a user. label Jul 15, 2020
@Templarian Templarian added High Priority Issue is a high priority. Home Assistant Icons related to home automation and more specifically, for use in Home Assistant. labels Jul 15, 2020
@Templarian
Copy link
Owner

Above has each version tagged. We pull it from the commit log, but might have messed up. Sorry about that.

When I wrap up work today I can go through and double check the changelog and report any missing items.

@mririgoyen
Copy link
Collaborator

I'm also checking right now. Better to have two sets of eyes on it.

@Templarian
Copy link
Owner

@bramkragten There were 470 changes in the 5.0.45 release. Looks like those two renames got left out.

  • visual-studio -> microsoft-visual-studio
  • visual-studio-code -> microsoft-visual-studio-code

@bramkragten
Copy link
Author

Thank you very much for double checking this!

@bramkragten
Copy link
Author

One final little remark, some icons are in the list in this issue #4901 that I used but are missing on the changelog/migration page https://dev.materialdesignicons.com/upgrade#4.9.95-to-5.0.45

Like library-video => play-box-multiple (that I found because it has a typo in that issue, play-box-mutiple -> play-box-multiple)

@Templarian
Copy link
Owner

@bramkragten Good catch! Pushed an update to fix these issues (should be on the site in ~5 minutes).

Our next release includes a lot of Home Assistant tagged icons, so it will be great to see the mappings working. 5.0 was our large break it for the future release, so relatively smooth now-a-days.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
High Priority Issue is a high priority. Home Assistant Icons related to home automation and more specifically, for use in Home Assistant. Question Question from a user.
Projects
None yet
Development

No branches or pull requests

3 participants