Charities should be able to edit outcomes on committed iterations

[jdudley1123]

I'm leaning towards yes, but maybe with review or notification for mentors.

The issue I have is I want them to commit to their iteration so the ball is rolling and they're doing check-ins etc., but also I want them to be able to refine their outcome language a bit. I'm envisaging small changes - making outcomes SMARTer etc. - rather than changing tack midway through.

What do you think @suninthesky, @trompodrone?

[suninthesky]

I'm game for this. Be cool to explore how we track/visualise changes to outcomes over time, perhaps related to #189 (comment)

Might have some implications for historic check-ins, i.e. making sure the outcomes they reference are at the right version.

[jdudley1123]

You could do something like Facebook has for edited posts where you can see the previous versions for comparison if you want.

Not sure how the schema would work. The simplest approach would I think just be to add a reference in each subsequent outcome record to the original one. That would also give us wiggle room if we wanted to make any other fields editable at the cost of some duplicated data storage.

[jdudley1123]

I've had a think about this:

Outcomes gain a new property, an enumerated status with values of something like current and past. If an outcome is edited, we don't actually update it, instead we change its status to past and make a new outcome that is current. We also send a notification email.

Old check-ins will continue to reference the past outcomes they were originally against, but any new check-ins/debrief will be against the current outcomes. Past versions of an outcome will be viewable in the iteration for comparison.

Doing this in the current iteration editing form could be tricky because it will require a bit of jiggery-pokery in the controller to identify whether the outcomes have been edited and then go through the process above. It might be easier to do outcome editing on a separate form (outcomes/#/edit) so that it's routed through a different controller. We could also then add a box for 'justification'.

How does that sound?