Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes from Legacy Verifier #2

Open
msmith-techempower opened this issue Jul 10, 2020 · 0 comments
Open

Changes from Legacy Verifier #2

msmith-techempower opened this issue Jul 10, 2020 · 0 comments

Comments

@msmith-techempower
Copy link
Member

msmith-techempower commented Jul 10, 2020

  • Query count verification used to have a threshold check in various cases. It was complicated and seemed unnecessary. However, it used to be that if you performed 98.5% of select statements on any db query test, it would warn on verification. This is now an error.
  • Fortune always had the requirement that the list be dynamically sized, but it was never enforced. The verification process now brute-forcefully adds ~10,000 fortunes to the table, then makes a request to the fortune end-point again and checks that all of the old and new fortunes are present (read: if a statically sized array/vector/list were used, this would fail).
  • Give a 1.5% margin of error acceptance to the MySQL implementation of get_count_of_all_queries_for_table.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant