-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React concurrent mode throws this error #9
Comments
we don't use refs in our code, so I guess it's an issue in your code. |
My bad. I was passing a reference to the SVG Icon, instead of an instantiated icon, so the React.cloneElement was throwing. Looks good in Concurrent mode actually! Btw, love the library. Would love to see this added MUI's official code base, as everyone should use your lib |
@NawarA I'm not sure if this component would be approved into Material-UI. It usually depends on demand, e.g. many people needed a rating component so one was included in Material-UI (although there were some community components). |
There is an open issue and feature request to add simple animations to material design. Your lib is the start of that :) |
Expected ref to be a function, a string, an object returned by React.createRef(), or null.
I believe its coming
React.cloneElement
The text was updated successfully, but these errors were encountered: