Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Expose more variables to be able to create dash manifests #461

Closed
FireMasterK opened this issue Nov 10, 2020 · 10 comments · Fixed by #810
Closed

[Request] Expose more variables to be able to create dash manifests #461

FireMasterK opened this issue Nov 10, 2020 · 10 comments · Fixed by #810

Comments

@FireMasterK
Copy link
Member

FireMasterK commented Nov 10, 2020

So, I'm trying to use NewPipe in a frontend with videojs, unfortunately, the extractor doesn't provide enough information to create a dash manifest for 1080p playback.

Is there any way to add the following to the VideoStream?

itag
codec
width
height
fps
initRange
indexRange
bitrate // different from averageBitrate

They are already in the JSON response, and youtube-dl already does this, so I don't see why not.

@FireMasterK FireMasterK changed the title [Request] Expose more variables to create dash manifests [Request] Expose more variables to be able to create dash manifests Nov 10, 2020
@Stypox
Copy link
Member

Stypox commented Nov 10, 2020

This will be done when NewPipe will finally get support for playing DASH. Basically this is the releavant PR (will be reopened soon): #367

@FireMasterK
Copy link
Member Author

I believe that's a unrelated PR because of the following:

  • That PR is involving the parsing of the mpd files
  • The following data is available in the parsing of the adaptive streams / videoonly/audio streams, parsing the dash file would be unnecessary in this case

NewPipe solves this issue by using a MergingMediaSource in exoplayer which unfortunately doesn't exist in videojs.

@Stypox
Copy link
Member

Stypox commented Nov 10, 2020

Yeah,that PR is not the ultimate solution, but it's the first step

@Stypox
Copy link
Member

Stypox commented Nov 17, 2020

Closing in favour of #223

@Stypox Stypox closed this as completed Nov 17, 2020
@FireMasterK
Copy link
Member Author

@Stypox
Isn't that a totally different issue? This one is related to the adaptiveStreams while that is regarding playback of dash videos.

@B0pol B0pol reopened this Feb 9, 2021
@B0pol
Copy link
Member

B0pol commented Feb 9, 2021

itag, fps, are already available in ItagItem

@FireMasterK
Copy link
Member Author

fps can be inaccurate at times since it's a hardcoded value (from the itag).

In this video, it would show up as 60 fps although it's 50. #488 fixes this already tho.

@harshmandan
Copy link

@FireMasterK is this issue resolved with you PR?

@FireMasterK
Copy link
Member Author

Yes it has, but dash manifest parsing needs to added to finish off everything.

@opusforlife2
Copy link
Collaborator

Now that DASH support has been added, you can finally make the front-end you wanted! You should call it... "Depip".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants