Add search type link

[Sola0404]

What is it?

• Bugfix (user facing)
• Feature (user facing)
• Codebase improvement (dev facing)
• Meta improvement to the project (dev facing)

Description of the changes in your PR

• Add SEARCH type case in the intent handler
• Add a method to generate an intent conveying the information of service id, URL, link type, and search string. This method is used in getIntentByLink when link type is SEARCH, distinguishing the conditions between using SEARCH link and open search.

Fixes the following issue(s)

Fixes #2313

PR relies on

TeamNewPipe/NewPipeExtractor#950

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

• I read the contribution guidelines.

[AudricV]

Could you explain better what you added in this pull request? Also, it seems you did extractor changes for this, but you didn't use them in this PR. Please do so if that's needed.

[Sola0404]

Thank you for your response. I've updated the description.
I changed extractor for this issue, but I don't know how to include these changes in this PR, cause they are from different repositories. Could you give me some advice? Thanks in advance!

[Stypox]

@Sola0404 You need to create a pull request in NewPipeExtractor, too. As you noticed, they are two different repositories, hence two different PRs ;-)

[ShareASmile]

@Sola0404 You need to create a pull request in NewPipeExtractor, too.

@Stypox it's already been opened on extractor TeamNewPipe/NewPipeExtractor#950

AudricV wrote:

it seems you did extractor changes for this, but you didn't use them in this PR. Please do so if that's needed.

Stypox @Sola0404 is asking how to use extractor commits in this PR

[opusforlife2]

Ah, @Sola0404 you should have followed the template more carefully. There is a section where you list which PR(s) this one relies on. You must link your Newpipe Extractor PR in your description.

You have to use the hash of the latest commit in your Newpipe Extractor PR branch, for example here is a commit hash to match this PR TeamNewPipe/NewPipeExtractor#810.

[Stypox]

Are urls copied to the search field in NewPipe handled as opened URLs?

[Stypox]

Intead of obtaining the ID this way, as said in TeamNewPipe/NewPipeExtractor#950 (comment), I think you should use service.getSearchLHFactory().getId(url).

[Stypox]

I'm closing this for now, both because of inactivity, and because we're going to start the rewrite soon and this would get conflicts despite its simplicity. I'm leaving TeamNewPipe/NewPipeExtractor#950 (comment) open though, so once that is done and the rewrite is in a good shape this can be reopened. Thank you!