Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening video quality/captions selector menu crashes on Quest #9862

Open
6 tasks done
DevanWolf opened this issue Feb 27, 2023 · 9 comments
Open
6 tasks done

Opening video quality/captions selector menu crashes on Quest #9862

DevanWolf opened this issue Feb 27, 2023 · 9 comments
Labels
bug Issue is related to a bug device/software specific Issues that only happen on some devices or with some specific hardware/software player Issues related to any player (main, popup and background)

Comments

@DevanWolf
Copy link

DevanWolf commented Feb 27, 2023

Checklist

  • I am able to reproduce the bug with the latest version.
  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I have read the FAQ and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one bug.
  • I have read and understood the contribution guidelines.

Affected version

0.27.2 and earlier

Steps to reproduce the bug

  1. Play any video
  2. Open the video quality/resolution setting menu (e.g. 720p)

Expected behavior

The quality list menu is supposed to show up as if it were viewing on other devices (phone/tablet).

Actual behavior

App crash

Screenshots/Screen recordings

No response

Logs

Opening video resolution menu on Quest crashes app

Exception

  • User Action: ui error
  • Request: ACRA report
  • Content Country: US
  • Content Language: en-US
  • App Language: en_US
  • Service: none
  • Version: 0.27.2
  • OS: Linux Android 12 - 32
Crash log

android.view.WindowManager$BadTokenException: Unable to add window -- token android.view.ViewRootImpl$W@5e5b01d is not valid; is your activity running?
	at android.view.ViewRootImpl.setView(ViewRootImpl.java:941)
	at android.view.WindowManagerGlobal.addView(WindowManagerGlobal.java:387)
	at android.view.WindowManagerImpl.addView(WindowManagerImpl.java:95)
	at android.widget.PopupWindow.invokePopup(PopupWindow.java:1577)
	at android.widget.PopupWindow.showAsDropDown(PopupWindow.java:1424)
	at androidx.appcompat.widget.AppCompatPopupWindow.showAsDropDown(AppCompatPopupWindow.java:77)
	at androidx.core.widget.PopupWindowCompat$Api19Impl.showAsDropDown(PopupWindowCompat.java:247)
	at androidx.core.widget.PopupWindowCompat.showAsDropDown(PopupWindowCompat.java:71)
	at androidx.appcompat.widget.ListPopupWindow.show(ListPopupWindow.java:757)
	at androidx.appcompat.view.menu.CascadingMenuPopup.showMenu(CascadingMenuPopup.java:487)
	at androidx.appcompat.view.menu.CascadingMenuPopup.show(CascadingMenuPopup.java:266)
	at androidx.appcompat.view.menu.MenuPopupHelper.showPopup(MenuPopupHelper.java:299)
	at androidx.appcompat.view.menu.MenuPopupHelper.tryShow(MenuPopupHelper.java:185)
	at androidx.appcompat.view.menu.MenuPopupHelper.show(MenuPopupHelper.java:147)
	at androidx.appcompat.widget.PopupMenu.show(PopupMenu.java:238)
	at org.schabi.newpipe.player.ui.VideoPlayerUi.onQualityClicked(VideoPlayerUi.java:1165)
	at org.schabi.newpipe.player.ui.VideoPlayerUi.onClick(VideoPlayerUi.java:1369)
	at org.schabi.newpipe.player.ui.MainPlayerUi.onClick(MainPlayerUi.java:863)
	at android.view.View.performClick(View.java:7259)
	at android.view.View.performClickInternal(View.java:7236)
	at android.view.View.access$3600(View.java:801)
	at android.view.View$PerformClick.run(View.java:27892)
	at android.os.Handler.handleCallback(Handler.java:886)
	at android.os.Handler.dispatchMessage(Handler.java:102)
	at android.os.Looper.loop(Looper.java:227)
	at android.app.ActivityThread.main(ActivityThread.java:7436)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:492)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:936)


Affected Android/Custom ROM version

Android 10/12L / Meta Quest Platform

Affected device model

Meta Quest 2/Pro/3

Additional information

Device is an HMD

@DevanWolf DevanWolf added bug Issue is related to a bug needs triage Issue is not yet ready for PR authors to take up labels Feb 27, 2023
@SameenAhnaf
Copy link
Collaborator

0.25.0 is the latest version. Please update to the latest version and check if the bug still persists.

@SameenAhnaf SameenAhnaf added template ignored The user didn't follow the template/instructions (or removed them) and removed bug Issue is related to a bug needs triage Issue is not yet ready for PR authors to take up labels Feb 27, 2023
@DevanWolf
Copy link
Author

Same problem on that latest version, even the caption menu does it.

@opusforlife2 opusforlife2 reopened this Mar 2, 2023
@opusforlife2 opusforlife2 added bug Issue is related to a bug GUI Issue is related to the graphical user interface player Issues related to any player (main, popup and background) device/software specific Issues that only happen on some devices or with some specific hardware/software and removed template ignored The user didn't follow the template/instructions (or removed them) labels Mar 2, 2023
@opusforlife2
Copy link
Collaborator

Update your description to state the correct version.

@opusforlife2 opusforlife2 added the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Mar 2, 2023
@github-actions
Copy link

This issue has been automatically closed because there has been no response to our request for more information from the original author. With only the information that is currently in the issue, we don't have enough information to take action. Please reach out if you have or find the answers we need so that we can investigate further.

@av01d1ngx4
Copy link

This error notice indicates that an attempt was made to add a new window to the currently running activity, but the activity may have been terminated or was not operating when the window was added.

This error can occur in a variety of situations, including attempting to display a dialog or a popup window after the activity has been destroyed, or attempting to display a popup window from a background thread.

@opusforlife2 opusforlife2 removed bug Issue is related to a bug GUI Issue is related to the graphical user interface player Issues related to any player (main, popup and background) device/software specific Issues that only happen on some devices or with some specific hardware/software waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. labels Mar 18, 2023
@DevanWolf
Copy link
Author

Bug is still present in the latest version (v0.27.0)

@opusforlife2
Copy link
Collaborator

opusforlife2 commented May 31, 2024

Update your description to state the correct version.

^

Also, replace that old crash report with one from the latest version, just so we can be sure the log is the same.

@opusforlife2 opusforlife2 reopened this May 31, 2024
@opusforlife2 opusforlife2 added the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label May 31, 2024
@DevanWolf DevanWolf changed the title Opening video quality menu crashes on Quest Opening video quality/captions selector menu crashes on Quest Jun 2, 2024
@DevanWolf
Copy link
Author

I did (assuming it's the same log).

@github-actions github-actions bot removed the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Jun 14, 2024
@opusforlife2 opusforlife2 added bug Issue is related to a bug player Issues related to any player (main, popup and background) device/software specific Issues that only happen on some devices or with some specific hardware/software labels Jun 15, 2024
@DevanWolf
Copy link
Author

Update your description to state the correct version.

^

Also, replace that old crash report with one from the latest version, just so we can be sure the log is the same.

Bug is still present in 0.27.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug device/software specific Issues that only happen on some devices or with some specific hardware/software player Issues related to any player (main, popup and background)
Projects
None yet
Development

No branches or pull requests

4 participants