Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a Blue Theme #8965

Closed
6 tasks done
CharleeBrown opened this issue Sep 13, 2022 · 7 comments
Closed
6 tasks done

Adding a Blue Theme #8965

CharleeBrown opened this issue Sep 13, 2022 · 7 comments

Comments

@CharleeBrown
Copy link

CharleeBrown commented Sep 13, 2022

Checklist

  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I have read the FAQ and my problem isn't listed.
  • I'm aware that this is a request for NewPipe itself and that requests for adding a new service need to be made at NewPipeExtractor.
  • I have taken the time to fill in all the required details. I understand that the feature request will be dismissed otherwise.
  • This issue contains only one feature request.
  • I have read and understood the contribution guidelines.

Feature description

The only change would be the color of the components. The overall functionality of the project would remain the same.

Why do you want this feature?

My favorite color is blue, and there were no blue themes. Also, I want to start contributing to open source projects and this seems like a good opportunity.

Additional information

Screenshot_20220912-150830_NewPipe Debug

@CharleeBrown CharleeBrown added feature request Issue is related to a feature in the app needs triage Issue is not yet ready for PR authors to take up labels Sep 13, 2022
@MDP43140
Copy link
Contributor

tbh that white text with bright cyan-blue background is unreadable, i prefer black text with white background, changing just the accent color to blue

@CharleeBrown
Copy link
Author

CharleeBrown commented Sep 13, 2022

@MDP43140 How's this?

Screenshot_20220913-140150_NewPipe Debug

Screenshot_20220913-140317_NewPipe Debug

@MDP43140
Copy link
Contributor

maybe its a bit better to reduce the cyan saturation a little bit, and also the "Trending", "NewPipe Debug", title color should be white

@Stypox
Copy link
Member

Stypox commented Sep 14, 2022

I don't think a new theme should be added to newpipe. Usually apps only provide light, dark and black themes. As per other themes:

  • they would be used by only really few people
  • they require maintenance effort
  • they can possibly create more situations to handle in the code, hence more bugs
  • if we start adding one colorful theme, why not adding more? People will start making requests, but we can't have tens of themes in NewPipe.

It's great that you want to start contributing to NewPipe! However I would not begin with this task because of the complexity of building a theme in Android. You may look at other tasks flagged as good-first-issue, instead.

@CharleeBrown
Copy link
Author

@Stypox Fair points. I'll look into the good-first-issues!

@Stypox Stypox closed this as completed Sep 14, 2022
@Stypox Stypox mentioned this issue Sep 14, 2022
4 tasks
@GameOverFlowChart
Copy link

Actually, using that experience could be used to implement Material You. Material you adapts the colours of the ui to the favourite colours of the user and avoids problems like unreadable colour combinations while every user has its own favourite colour. We don't need to reinvent the wheel, Material You was introduced to solve exactly this kind of problems. Use adaptivity instead of making decisions for the end user.

@tsiflimagas
Copy link
Contributor

Then you may upvote #7595.

@SameenAhnaf SameenAhnaf removed feature request Issue is related to a feature in the app needs triage Issue is not yet ready for PR authors to take up labels Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants