Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit number of downloads running in parallel #4215

Closed
KapilFaujdar opened this issue Sep 3, 2020 · 9 comments
Closed

Limit number of downloads running in parallel #4215

KapilFaujdar opened this issue Sep 3, 2020 · 9 comments
Labels
bug Issue is related to a bug downloader Issue is related to the downloader duplicate Issue or discussion is a duplicate of an existing issue or discussion

Comments

@KapilFaujdar
Copy link

Version

  • 0.19.8

Steps to reproduce the bug

When multiple videos are downloaded. More than one video start downloading while the settings are configured to download one video at a time.

Expected behavior

Only one video should be downloaded.

Actual behaviour

Four videos from the queue start downloading simultaneously.

Screenshots/Screen recordings

Screenshot_20200903-092931055
Screenshot_20200903-092915826

Logs

@KapilFaujdar KapilFaujdar added the bug Issue is related to a bug label Sep 3, 2020
@opusforlife2
Copy link
Collaborator

Works fine here. Please provide additional info like device and Android version. And if you're using any VPNs or other network modifiers.

@KapilFaujdar
Copy link
Author

Motorola G5 plus with Android 10.

Happens when many files are in queue and download is restarted after it was stopped manually or by network error.

@opusforlife2
Copy link
Collaborator

Happens when many files are in queue and download is restarted after it was stopped manually or by network

See now this is something you should put in the template when you first open the issue. Otherwise the tester can be misled. Always give as much information as possible about your investigation into the problem.

@opusforlife2
Copy link
Collaborator

and download is restarted

How are you restarting it? By tapping the play button in the top right corner? Or by tapping Start in that download's 3 dot menu?

@Stypox Stypox added the downloader Issue is related to the downloader label Sep 3, 2020
@KapilFaujdar
Copy link
Author

By tapping the button at top

@opusforlife2
Copy link
Collaborator

Thought so. If you long press on the button you'll see that it's called Start Downloads. Which means it starts all the downloads at once. If you want to start a single download, you have to tap the Start option from its 3 dot menu.

@Stypox The idea makes sense. If a person enables the limit queue option, then that button should only restart the pending download and recreate the queue, instead of starting them all at once.

Also, the wording "Limit download queue" doesn't make sense. It should be called "Enable/disable parallel downloads". Limit queue would mean that we don't allow the user to queue more than x videos for downloading. That's not the case. The queue has no upper bound (I think).

@Stypox Stypox changed the title 'Limit download queue' option is not honoured Limit number of downloads running in parallel Sep 6, 2020
@NomarCub
Copy link

NomarCub commented Aug 1, 2022

Is there a ticket for an actual "Limit download queue" feature (as in limit them to a number)? I looked around, but the issues are a mess.

@opusforlife2
Copy link
Collaborator

If you've searched for duplicates and not found any, you can always open a new issue.

@opusforlife2
Copy link
Collaborator

Closing in favour of #11360.

@opusforlife2 opusforlife2 added the duplicate Issue or discussion is a duplicate of an existing issue or discussion label Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug downloader Issue is related to the downloader duplicate Issue or discussion is a duplicate of an existing issue or discussion
Projects
None yet
Development

No branches or pull requests

4 participants