Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Lock screen rotation status #2925

Closed
MF-Debug opened this issue Jan 5, 2020 · 6 comments
Closed

[Feature request] Lock screen rotation status #2925

MF-Debug opened this issue Jan 5, 2020 · 6 comments
Assignees
Labels
feature request Issue is related to a feature in the app player Issues related to any player (main, popup and background)

Comments

@MF-Debug
Copy link

MF-Debug commented Jan 5, 2020

It would be very handy if we can lock the screen rotation to either portrait or landscape when viewing a video in any of the mentioned state so that the screen doesn't go back to another state while moving the phone.

@Stypox
Copy link
Member

Stypox commented Jan 6, 2020

It already works this way... when I open a video fullscreen I can't change rotation unless I click the corresponding button: moving the phone does nothing

@MF-Debug
Copy link
Author

MF-Debug commented Jan 6, 2020

i meant the behavior when auto-rotation is also enabled via the quick toggle menu

@Stypox
Copy link
Member

Stypox commented Jan 6, 2020

Since the option already exists in the phone's quick toggle menu, I don't see the point of adding it to NewPipe

@MF-Debug MF-Debug closed this as completed Jan 6, 2020
@TobiGr TobiGr added the question Not really an issue, but more of a question about how something works label Jan 6, 2020
@TobiGr
Copy link
Contributor

TobiGr commented Jan 6, 2020

i meant the behavior when auto-rotation is also enabled via the quick toggle menu

To lock the player orientation, tap on the screen and you'll se the normal overlay. Tap on the arrow on the right site to collapse a menu. Tap on the
image icon to lock the player orientation.

@MF-Debug
Copy link
Author

MF-Debug commented Jan 6, 2020

how could i haven't seen that button! that's what i needed, thank you!

@Stypox Stypox reopened this Jan 6, 2020
@B0pol B0pol added feature request Issue is related to a feature in the app and removed question Not really an issue, but more of a question about how something works labels Oct 15, 2020
@B0pol B0pol self-assigned this Oct 15, 2020
@B0pol B0pol added the player Issues related to any player (main, popup and background) label Oct 15, 2020
@Stypox
Copy link
Member

Stypox commented Mar 25, 2021

Closing in favour of #4500 as this refers to pre-unified and everything changed when the fire nation we developers attacked (sorry I could not stop ;-) )

@Stypox Stypox closed this as completed Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app player Issues related to any player (main, popup and background)
Projects
None yet
Development

No branches or pull requests

4 participants