-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"day" and "days" often get localised using the system's language instead of the app language #11148
Comments
Seems like the bug is not being caused by NewPipe itself but prettytime. Its localization for italian isn't correct. |
What do you mean? How can that be the case? |
Prettytime is an external library that is used by NewPipe to localize upload dates. The problem is that there is a bug in prettytime that is causing the problems that you're describing. I'm writing a ticket to the people who made prettytime so that hopefully this issue is resolved. |
This is what I have an issue with. You said that the problem is with the library's Italian localisation, but the Italian localisation should not be used at all because I selected "English" in "Settings" -> "Content" -> "App Language". |
And if I select Italian as app language, NewPipe will show "1 giorno fa"/"4 giorni fa", so the correct Italian translations for "1 day ago"/4 days ago", not "1 giorno ago"/"4 giorni ago". I don't doubt that the issue could still be with the library, and not NewPipe directly, but I don't have evidence of that. |
Let's see if there's a response on that issue. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
This issue has been automatically closed because there has been no response to our request for more information from the original author. With only the information that is currently in the issue, we don't have enough information to take action. Please reach out if you have or find the answers we need so that we can investigate further. |
What is the point of closing the issue if the bug wasn't fixed? |
Was giving it some time to see if the PrettyTime devs replied. Since they haven't, let's just keep this open. Maybe someone will come across this and wish to fix it themselves. |
Checklist
Affected version
0.27.0
Steps to reproduce the bug
My smartphone's main language is "Italian", but I have selected "English" as App Language in "Settings" -> "Content" -> "App language" -> "English".
Expected behavior
The words "day" and "days" should be displayed as "day" and "days" in the UI.
Actual behavior
"day" and "days" are often shown as "giorno" and "giorni" (i.e. "day" and "days" in Italian, the system's main language).
Sometimes they get displayed as "day" and "days" after you close/re-open the app or go to another app and come back to NewPipe, but not always.
Screenshots/Screen recordings
Logs
No response
Affected Android/Custom ROM version
Android 13 / One UI Core 5.1
Affected device model
Samsung Galaxy A22 5G
Additional information
I have started noticing this problem since I started using NewPipe on this phone on which I am using Italian as system language, it was also happening in version
0.26.0
.It only occurs for "day" and "days" as far as I can tell.
The text was updated successfully, but these errors were encountered: