Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"day" and "days" often get localised using the system's language instead of the app language #11148

Open
6 tasks done
emanuele6 opened this issue Jun 14, 2024 · 12 comments
Open
6 tasks done
Labels
bug Issue is related to a bug localisation / translation Everything that has to do with translations or Weblate

Comments

@emanuele6
Copy link

emanuele6 commented Jun 14, 2024

Checklist

  • I am able to reproduce the bug with the latest version given here: CLICK THIS LINK.
  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I have read the FAQ and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one bug.
  • I have read and understood the contribution guidelines.

Affected version

0.27.0

Steps to reproduce the bug

My smartphone's main language is "Italian", but I have selected "English" as App Language in "Settings" -> "Content" -> "App language" -> "English".

Expected behavior

The words "day" and "days" should be displayed as "day" and "days" in the UI.

Actual behavior

"day" and "days" are often shown as "giorno" and "giorni" (i.e. "day" and "days" in Italian, the system's main language).
Sometimes they get displayed as "day" and "days" after you close/re-open the app or go to another app and come back to NewPipe, but not always.

Screenshots/Screen recordings

file

Logs

No response

Affected Android/Custom ROM version

Android 13 / One UI Core 5.1

Affected device model

Samsung Galaxy A22 5G

Additional information

I have started noticing this problem since I started using NewPipe on this phone on which I am using Italian as system language, it was also happening in version 0.26.0.
It only occurs for "day" and "days" as far as I can tell.

@emanuele6 emanuele6 added bug Issue is related to a bug needs triage Issue is not yet ready for PR authors to take up labels Jun 14, 2024
@opusforlife2 opusforlife2 added localisation / translation Everything that has to do with translations or Weblate and removed needs triage Issue is not yet ready for PR authors to take up labels Jun 15, 2024
@emanuele6 emanuele6 changed the title "day" and "days" often get internationalised using the system's language instead of the app language "day" and "days" often get localised using the system's language instead of the app language Jun 15, 2024
@frop-qart
Copy link

Seems like the bug is not being caused by NewPipe itself but prettytime. Its localization for italian isn't correct.

@emanuele6
Copy link
Author

emanuele6 commented Aug 8, 2024

What do you mean? How can that be the case?
The bug is that NewPipe uses the system language ("Italian") instead of the app language ("English") for "day"/"days" pretty much all the time.
It also happens pretty often that NewPipe will use the system language instead of the selected app language for the entire UI, not just "day"/days", when the app is reopened after being closed for a while.
There are no translation mistakes.

@frop-qart
Copy link

Prettytime is an external library that is used by NewPipe to localize upload dates. The problem is that there is a bug in prettytime that is causing the problems that you're describing. I'm writing a ticket to the people who made prettytime so that hopefully this issue is resolved.

@emanuele6
Copy link
Author

emanuele6 commented Aug 8, 2024

A screenshot to show that the problem does not occur 100% of the times (here the only system language is "Italian", and the selected app langauge in NewPipe is "English")

Screenshot_20240808_195322_NewPipe

I've now changed my smartphone's system languages so that "Finnish" is the only language, if I see that the word for "day"/"days" is not rendered in English, I will post a screenshot to show that this problem happens with not just Italian.

@emanuele6
Copy link
Author

@frop-qart

Its localization for italian isn't correct.

This is what I have an issue with.

You said that the problem is with the library's Italian localisation, but the Italian localisation should not be used at all because I selected "English" in "Settings" -> "Content" -> "App Language".

@emanuele6
Copy link
Author

emanuele6 commented Aug 8, 2024

And if I select Italian as app language, NewPipe will show "1 giorno fa"/"4 giorni fa", so the correct Italian translations for "1 day ago"/4 days ago", not "1 giorno ago"/"4 giorni ago".

I don't doubt that the issue could still be with the library, and not NewPipe directly, but I don't have evidence of that.
And I very much doubt that the problem will only occur if you have Italian as only system language as you are suggesting.

@opusforlife2
Copy link
Collaborator

Let's see if there's a response on that issue.

@opusforlife2 opusforlife2 added the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Aug 9, 2024

This comment was marked as outdated.

@emanuele6

This comment was marked as resolved.

@github-actions github-actions bot removed the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Aug 24, 2024
@github-actions github-actions bot reopened this Aug 24, 2024
@opusforlife2 opusforlife2 added the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Sep 19, 2024
Copy link

github-actions bot commented Oct 5, 2024

This issue has been automatically closed because there has been no response to our request for more information from the original author. With only the information that is currently in the issue, we don't have enough information to take action. Please reach out if you have or find the answers we need so that we can investigate further.

@github-actions github-actions bot closed this as completed Oct 5, 2024
@emanuele6
Copy link
Author

What is the point of closing the issue if the bug wasn't fixed?

@github-actions github-actions bot removed the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Oct 5, 2024
@github-actions github-actions bot reopened this Oct 5, 2024
@opusforlife2
Copy link
Collaborator

Was giving it some time to see if the PrettyTime devs replied. Since they haven't, let's just keep this open. Maybe someone will come across this and wish to fix it themselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug localisation / translation Everything that has to do with translations or Weblate
Projects
None yet
Development

No branches or pull requests

3 participants