Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upload dates have a minus prepended if they're in the past and language is set to Ukrainian #11092

Closed
6 tasks done
moontoaster opened this issue May 23, 2024 · 1 comment · Fixed by #11094
Closed
6 tasks done

Upload dates have a minus prepended if they're in the past and language is set to Ukrainian #11092

moontoaster opened this issue May 23, 2024 · 1 comment · Fixed by #11094
Labels
bug Issue is related to a bug dependency Issues and PRs related to dependencies good first issue Easy/simple issues perfect for newcomers to get involved in the project GUI Issue is related to the graphical user interface localisation / translation Everything that has to do with translations or Weblate

Comments

@moontoaster
Copy link
Contributor

moontoaster commented May 23, 2024 •
edited by github-actions bot
Loading

Checklist

  • I am able to reproduce the bug with the latest version given here: CLICK THIS LINK.
  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I have read the FAQ and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one bug.
  • I have read and understood the contribution guidelines.

Affected version

0.27.0

Steps to reproduce the bug

  1. Set the app language to Ukrainian, either through NewPipe's Settings -> Content -> App language or by setting the system language to Ukrainian
  2. Open NewPipe
  3. Go to any screen with upload dates (e.g. 10 hours ago) displayed
  4. Look at the upload dates

Expected behavior

Upload date does not have a minus prepended to it (e.g. "10 годин тому")

Actual behavior

Upload date has a minus prepended to it (e.g. "-10 годин тому")

Screenshots/Screen recordings

Bug on the "New" page (notice the minuses highlighted by red circles):
newpipe bug report

Logs

No response

Affected Android/Custom ROM version

No response

Affected device model

No response

Additional information

This bug occurs due to a bug in the 5.0.7 version of the PrettyTime library, which was fixed in 5.0.8. Upgrading PrettyTime to that version fixes the bug:
newpipe bug fixed
@moontoaster moontoaster added bug Issue is related to a bug needs triage Issue is not yet ready for PR authors to take up labels May 23, 2024
@AudricV AudricV added good first issue Easy/simple issues perfect for newcomers to get involved in the project GUI Issue is related to the graphical user interface localisation / translation Everything that has to do with translations or Weblate dependency Issues and PRs related to dependencies and removed needs triage Issue is not yet ready for PR authors to take up labels May 23, 2024
moontoaster added a commit to moontoaster/NewPipe that referenced this issue May 23, 2024
@moontoaster
Update PrettyTime to 5.0.8
e48ce5a 
This version contains a fix for Ukrainian locale which fixes TeamNewPipe#11092.
@moontoaster moontoaster mentioned this issue May 23, 2024
Merged
5 tasks
@moontoaster
Copy link
Contributor Author

I've created a PR that fixes this: #11094

ShareASmile added a commit to ShareASmile/NewPipeZing that referenced this issue Jun 13, 2024
@ShareASmile @TobiGr
@Stypox @moontoaster
Fix (SoundCloud large playlist can’t load)[TeamNewPipe#10012]
c3b2dbe 
1. Copy this commit by StyPox
TeamNewPipe@e236d37
Fixes TeamNewPipe#10012

2. Update Extractor to Detect whether for SoundCloud there are any more search results
ShareASmile/NewPipeExtractor#41

Update date time library prettytime to 5.0.8.Final
Fixes: TeamNewPipe#11092

3. Fixes: Upload dates have a minus prepended if they're in the past and language is set to Ukrainian
Fixed in ocpsoft/prettytime#270

Co-Authored-By: Tobi <[email protected]>
Co-Authored-By: Stypox <[email protected]>
Co-Authored-By: moontoaster <[email protected]>
ShareASmile added a commit to ShareASmile/NewPipeZing that referenced this issue Jun 13, 2024
@ShareASmile @moontoaster
Update date time library prettytime to 5.0.8.Final Fixes: TeamNewPip…
a1e60f0 
…e… …TeamNewPipe#11092

Fixes: Upload dates have a minus prepended if they're in the past and language is set to Ukrainian
Fixed in ocpsoft/prettytime#270

Co-Authored-By: moontoaster <[email protected]>
rx78gp01 pushed a commit to rx78gp01/NewPipe that referenced this issue Jul 11, 2024
@moontoaster @rx78gp01
Update PrettyTime to 5.0.8
2afa17f 
This version contains a fix for Ukrainian locale which fixes TeamNewPipe#11092.
rx78gp01 pushed a commit to rx78gp01/NewPipe that referenced this issue Jul 11, 2024
@moontoaster @rx78gp01
Update PrettyTime to 5.0.8
aff7bdd 
This version contains a fix for Ukrainian locale which fixes TeamNewPipe#11092.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Issue is related to a bug dependency Issues and PRs related to dependencies good first issue Easy/simple issues perfect for newcomers to get involved in the project GUI Issue is related to the graphical user interface localisation / translation Everything that has to do with translations or Weblate
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update PrettyTime to 5.0.8 moontoaster/NewPipe
2 participants
@AudricV @moontoaster