Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "copy to clipboard" ability for Share icon below video #10299

Open
6 tasks done
sky-cake opened this issue Aug 4, 2023 · 10 comments
Open
6 tasks done

Add "copy to clipboard" ability for Share icon below video #10299

sky-cake opened this issue Aug 4, 2023 · 10 comments
Labels
feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface

Comments

@sky-cake
Copy link

sky-cake commented Aug 4, 2023

Checklist

  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I have read the FAQ and my problem isn't listed.
  • I'm aware that this is a request for NewPipe itself and that requests for adding a new service need to be made at NewPipeExtractor.
  • I have taken the time to fill in all the required details. I understand that the feature request will be dismissed otherwise.
  • This issue contains only one feature request.
  • I have read and understood the contribution guidelines.

Feature description

  1. Add Copy to Clipboard option after long hold on video component -> tapping Share
  2. Add Copy to Clipboard in video player where the globe and share icons are, or as part of the menu that appears after tapping the share icon, or to the video data menu.

Essentially, just add the Copy to Clipboard ability for YouTube videos anywhere.

Why do you want this feature?

Right now, in order to copy a YouTube video link to my clipboard, I must either

  1. Tap the globe icon in the video player, get taken to my Android browser, highlight the URL address and copy it.
    or
  2. Tap the share icon in the video player, select a method to send the URL (e.g. send myself the link through Signal), go to that app, and copy the address.
    or
  3. Similar to 2. but tap and holding on a video component then selecting Share. Sent the URL to a messaging app, go to that app and copy the address.

It would be much faster to just tap a copy icon from the video player, or other menu.

Additional information

I am using the latest version of NewPipe, v0.25.2.
I am running Android 9, One UI version 1.0

@sky-cake sky-cake added feature request Issue is related to a feature in the app needs triage Issue is not yet ready for PR authors to take up labels Aug 4, 2023
@SameenAhnaf SameenAhnaf added GUI Issue is related to the graphical user interface and removed needs triage Issue is not yet ready for PR authors to take up labels Aug 4, 2023
@Aleovas
Copy link

Aleovas commented Aug 5, 2023

This already exists. Hold tap on the share button

@SameenAhnaf
Copy link
Collaborator

This feature is already available on video player. Long press on share icon lets you copy link with timestamp.

However, this feature is still unavailable for share icon of video details. So, this issue will remain open.

@ChaosNicro
Copy link

Well I'm not sure if this differs in Android versions, but A10-12 has a copy button at the very top of the native share menu. Is this really not convenient enough?

@opusforlife2
Copy link
Collaborator

OP is on Android 9.

@sky-cake
Copy link
Author

sky-cake commented Aug 7, 2023

This already exists. Hold tap on the share button

Thanks, while I've tried tapping the share button, I didn't know about hold-tapping it. Thank you!

@sky-cake sky-cake closed this as completed Aug 7, 2023
@opusforlife2
Copy link
Collaborator

However, this feature is still unavailable for share icon of video details. So, this issue will remain open.

Sigh. You weren't supposed to close it, OP.

@opusforlife2 opusforlife2 reopened this Aug 7, 2023
@opusforlife2 opusforlife2 changed the title Add "copy to clipboard" ability for YouTube video. Add "copy to clipboard" ability for Share icon below video Aug 7, 2023
@lsahnicne
Copy link

I still would like to advocate for OP's original request. Hold-tapping the share icon is just so unintuitive - I never would have discovered it on my own have I not found this thread. Access to such basic functionality should not rely on esoteric knowledge.

@syphyr
Copy link

syphyr commented Nov 28, 2023

When I select share then copy to clipboard, I get an endless message popping up that Google Drive is unable to start. Using Android 7.1 and latest newpipe source on master branch.

@syphyr
Copy link

syphyr commented Nov 28, 2023

If I remove Google Drive, then the option to copy to clipboard is removed also...

@opusforlife2
Copy link
Collaborator

That means your copy to clipboard entry was being provided by that app.

Also, instead of making multiple consecutive comments, it's better to edit the existing one, especially if the topic is the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface
Projects
None yet
Development

No branches or pull requests

7 participants